unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: Charles Rendleman <carendle@gmail.com>
Cc: 18007@debbugs.gnu.org
Subject: bug#18007: 24.3.92: eww-download-callback, patch included
Date: Tue, 04 Nov 2014 11:39:04 -0500	[thread overview]
Message-ID: <87ioiu7wev.fsf@lifelogs.com> (raw)
In-Reply-To: <m2tx6ml0xo.fsf@charless-air.home> (Charles Rendleman's message of "Sat, 12 Jul 2014 17:30:43 -0400")

On Sat, 12 Jul 2014 17:30:43 -0400 Charles Rendleman <carendle@gmail.com> wrote: 

CR> Originally filed incorrectly under Emacs 23; this bug is with the
CR> 24.3.92 pretest

CR> eww-download-callback should remove the HTTP header before saving the file
CR> after a download.

CR> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
CR> index 02fc575..cff85a5 100644
CR> --- a/lisp/net/eww.el
CR> +++ b/lisp/net/eww.el
CR> @@ -1075,7 +1075,9 @@ Differences in #targets are ignored."
CR>             (path (car (url-path-and-query obj)))
CR>             (file (eww-make-unique-file-name (file-name-nondirectory path)
CR>                                             eww-download-directory)))
CR> -      (write-file file)
CR> +      (goto-char 0)
CR> +      (re-search-forward "\r?\n\r?\n")
CR> +      (write-region (point) (point-max) file)
CR>        (message "Saved %s" file))))

CR>  (defun eww-make-unique-file-name (file directory)

Would that work correctly with all encodings?  Multipart?  Binary data?

Is there a better way to extract the data in the url library?

Thanks
Ted





  parent reply	other threads:[~2014-11-04 16:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12 21:30 bug#18007: 24.3.92: eww-download-callback, patch included Charles Rendleman
2014-07-13  8:09 ` Andreas Schwab
2014-11-04 16:39 ` Ted Zlatanov [this message]
2014-11-10 20:56   ` Lars Magne Ingebrigtsen
2014-11-05 16:55 ` bug#18007: 24.3.92: eww-download-callback, better " Kentaro NAKAZAWA
2014-11-10 20:56 ` bug#18007: 24.3.92: eww-download-callback, " Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ioiu7wev.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=18007@debbugs.gnu.org \
    --cc=carendle@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).