From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#24766: 26.0.50: [PATCH] Confusing behaviour for indent-relative-maybe Date: Mon, 24 Oct 2016 13:27:43 -0600 Message-ID: <87insh4keo.fsf@gmail.com> References: <8760ok8ays.fsf@gmail.com> <83lgxgp4ts.fsf@gnu.org> <871sz8894m.fsf@gmail.com> <83h984p3lb.fsf@gnu.org> <87shro6ol6.fsf@gmail.com> <83a8dvpor2.fsf@gnu.org> <87twc2iynm.fsf@gmail.com> <837f8y5f5x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1477337310 29369 195.159.176.226 (24 Oct 2016 19:28:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Oct 2016 19:28:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24766@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 24 21:28:26 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bykuw-0006Mg-SI for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Oct 2016 21:28:19 +0200 Original-Received: from localhost ([::1]:49323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bykuz-0004LE-5i for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Oct 2016 15:28:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bykuj-0004H5-SY for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2016 15:28:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bykug-0005Yw-KM for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2016 15:28:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39416) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bykug-0005Yl-He for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2016 15:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bykug-00079u-7Q for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2016 15:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Oct 2016 19:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24766-submit@debbugs.gnu.org id=B24766.147733727427501 (code B ref 24766); Mon, 24 Oct 2016 19:28:02 +0000 Original-Received: (at 24766) by debbugs.gnu.org; 24 Oct 2016 19:27:54 +0000 Original-Received: from localhost ([127.0.0.1]:54815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bykuX-00079V-Qv for submit@debbugs.gnu.org; Mon, 24 Oct 2016 15:27:53 -0400 Original-Received: from mail-oi0-f49.google.com ([209.85.218.49]:32777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bykuV-00079H-Pj for 24766@debbugs.gnu.org; Mon, 24 Oct 2016 15:27:52 -0400 Original-Received: by mail-oi0-f49.google.com with SMTP id y2so55733587oie.0 for <24766@debbugs.gnu.org>; Mon, 24 Oct 2016 12:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=q0p/57IzSZnZMXvCgo8VnPftt8gk5gPgDhofKBp6oI4=; b=dODmJVZg7D25PsirwM9jyy/fKo4Xj0OcuaADWedSeAbKPxqHQbpqf3jHfkSFK823ri cFp9EC0Y627TV/2YgaAVcCQ5piOWUjR93aLmH7mhywJPDAO+mDTkkztV2wiu2et6AxtQ WtBNLWmRLYZu5ZHDlWfOGmtdpcT3ihrcXnyBE5QuolBbdM9XC1tnA8WpvFMk62iHoXc/ FDwAATKnqEtmOaFmkVCfE1Q+hRzMLYI4MUDM4a8HEXB3yE6VkopNQSFgIx8W6dav8Y4m W4HjLUejBgGSnwynhogel+LAzrJ3Bt/ZwCn1vptL0AaIh+wMefrCxYOBf7QAhhuT780y fBFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=q0p/57IzSZnZMXvCgo8VnPftt8gk5gPgDhofKBp6oI4=; b=dfscTYdEaCLqAje+t2MZvbncBp7ilJtkEjFO2mzYRygVIPrJfvKAYQJrLPQO1CCLC5 MCXCfENVA5x/RtqVWB15yFysp790PVgkM3OK9iWwevy52EL3RxMLb0/PUNHKTiUGQI2g hWWYz5k9vmHIaGeHRgu8ZPKiNXOCVfrX82YP9QjQKRHVMGe6A6asUcuUtjhONHK+vqji TFXGdEMGw5UojNhmXiOh6myeLbO9dqZnvv2dyySIfw1A2RTMNdTQm59Fj9GqOcBCWTCJ qwNq9X1Ng4eHYh4vmnzb5qz7cRK7RpEAdr0X95IuyyG8G4rUCogxVlnhtEstq2I9H0ZI 8T2w== X-Gm-Message-State: ABUngvfqN9CmD+IGv6zh+YpViJSCv/pGNe2QIQvcZKlv1HRWRvsLbcYHouS58d4l+NLydQ== X-Received: by 10.107.23.132 with SMTP id 126mr13304679iox.162.1477337265859; Mon, 24 Oct 2016 12:27:45 -0700 (PDT) Original-Received: from lylat (S01061859339e9903.ss.shawcable.net. [174.2.107.88]) by smtp.gmail.com with ESMTPSA id a100sm7931305ioj.13.2016.10.24.12.27.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Oct 2016 12:27:45 -0700 (PDT) In-Reply-To: <837f8y5f5x.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Oct 2016 11:23:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124969 Archived-At: Eli Zaretskii writes: >> From: Alex >> Cc: 24766@debbugs.gnu.org >> Date: Sun, 23 Oct 2016 14:43:57 -0600 >> >> What about changing `indent-relative-maybe' and adding an extra argument >> to `indent-relative'? Since `indent-relative-maybe' has had that >> docstring for a good 15 years, and the name fits the new behaviour more. >> >> Then in Emacs core we can replace the single instance of it with >> (indent-relative t). The corresponding diff: > > I'd prefer a backward-compatible change, i.e. make the new argument be > the 2nd one, and keep the current behavior when the 1st arg is non-nil > and the 2nd is nil or omitted. That's what I did, but I used a new name for the old argument and the old name for the new argument. I did so as the old name fits the new behaviour more. This is a backward-compatible change for indent-relative, but it does use the new behaviour for indent-relative-maybe. Is that alright with you? > Also, please add the necessary text to the doc string to document the > new argument. Sure, I'll do that once the code changes are agreed upon. > Thanks.