From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#25158: [PATCH] A better way for test code to access messages Date: Sat, 10 Dec 2016 20:27:38 +0100 Message-ID: <87inqrlh3p.fsf@gmx.de> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481398098 27467 195.159.176.226 (10 Dec 2016 19:28:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Dec 2016 19:28:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25158@debbugs.gnu.org To: Gemini Lasswell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 10 20:28:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFnJZ-0005jh-VS for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Dec 2016 20:28:10 +0100 Original-Received: from localhost ([::1]:52856 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFnJd-0008Vl-Rh for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Dec 2016 14:28:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFnJV-0008Us-2i for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2016 14:28:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFnJR-0002ws-VQ for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2016 14:28:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cFnJR-0002wn-TI for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2016 14:28:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cFnJR-0007Hw-Kj for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2016 14:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2016 19:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25158-submit@debbugs.gnu.org id=B25158.148139807127995 (code B ref 25158); Sat, 10 Dec 2016 19:28:01 +0000 Original-Received: (at 25158) by debbugs.gnu.org; 10 Dec 2016 19:27:51 +0000 Original-Received: from localhost ([127.0.0.1]:37255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFnJH-0007HT-5J for submit@debbugs.gnu.org; Sat, 10 Dec 2016 14:27:51 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:64104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFnJE-0007HC-N2 for 25158@debbugs.gnu.org; Sat, 10 Dec 2016 14:27:49 -0500 Original-Received: from detlef.gmx.de ([87.146.49.139]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0McUnM-1by7vo2uA4-00Hgjp; Sat, 10 Dec 2016 20:27:40 +0100 In-Reply-To: (Gemini Lasswell's message of "Sat, 10 Dec 2016 09:29:05 -0800") X-Provags-ID: V03:K0:OcTgSheSCUaR5GDAkr15iLciv7SsjpGRTdCXDI8dJccoS5iC+uE oZ0gGnlTzu8dTW3u7+aT9t8qQdy5ZTqRPSP4FhvIaXWENYTup8gXJHVjgtAZI73XgR+al+o ANHK7kn5smG6txztVfeCiNU41+1y3SQkvcUKu6e5mFwSmDojXs/g/GDYmJUbkNRuGM4SXaa DOLUgE0pMznnGdTTYU2fQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:1Rwi5S64P0k=:rTQRf+UVnmie0yEcDxQ/h3 yci58WzobGAA4B5oEYkM5pTOpRElF6I78llSl6NzZSeLdIYvEAkZAD6ncdU0IV8Fg7miEHKqb kAs8L/CKe4MhzEhkwx++ytKOGyyGPjVmVnt2le7ipi4wy6aW4kMkTkagFQaQidSC6FX+T409w Z8Ei1ZUeVS8XbKMwZWiefZzDSyisGcsPRbBECfN8aWyJmVSuktMO90cCWFEd0JBMgYT2y0gpE 7Q3PsevO3g2p0Y58KDuNH3grZ46avfv1175jqUisDihaFhL4sXHFYbkvMXuRdP2tLgryxqbfC uXQTAg7dkI7UxYvWD4EQxHGmOLp/NEZLIdotTteor1x4I4ui6UqnJ5sc9ItKwJDsZW10gDPnH y9iTN3H3W47jbA7gbDkfMnzQ5HM16kXZYHayVM8on7mXGBbz4WkezRtxSGc2LiX+V39nzJKaS HIVuA7KeHqAE205t5MyyPDUXFAfTtnv5tDxRTIf0s6p72gqy1XF6cKS/61KGe4j2Q2iufvBEK fLIL3e4G5WyjEBOiRZQyKOSwZtD0ugaBAp4X7KPm/9vN+w/vXwPYLIfqk0TnhHEdzfATu1ter B2uIg5UMHtf+KLH0Wcpj2RVciKEkQNZf7yQ13d/Dzc8XqROS+PozmCjhcLG0a7/iLA9e5W+UK Xq4iYDjLBbEyJaNxhvPsT1OzVV7ab73D/w5czTImMC83aEvop48lzh839OFSECUlMz7E4tEns OmLiwNYOebhceabH2AyaDKkepqrPQIOkdz4UZ9eusblQFIp1TfbscCm1MeYYxli2nR+dTnhq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126825 Archived-At: Gemini Lasswell writes: > Michael, in modifying autorevert-tests.el, at the start of > auto-revert-test02-auto-revert-deleted-file, *Messages* was narrowed, > and then narrowed again before the call to auto-revert--wait-for-revert, > so it looked safe to delete the first narrowing instead of replacing it > with ert-with-message-capture. Let me know if I've missed something > there. In autorevert-tests.el, the *Messages* buffer is narrowed systematically prior any write-region call. I don't remember the details, but AFAIR there were some other messages which have poisoned the tests. I let it to you to change wherever you feel it is necessary. Tests will show whether there are undesired side effects. Best regards, Michael.