From: Michael Albinus <michael.albinus@gmx.de>
To: Gemini Lasswell <gazally@runbox.com>
Cc: 25158@debbugs.gnu.org
Subject: bug#25158: [PATCH] A better way for test code to access messages
Date: Sat, 10 Dec 2016 20:27:38 +0100 [thread overview]
Message-ID: <87inqrlh3p.fsf@gmx.de> (raw)
In-Reply-To: <m2d1gzr8v2.fsf@rainbow.local> (Gemini Lasswell's message of "Sat, 10 Dec 2016 09:29:05 -0800")
Gemini Lasswell <gazally@runbox.com> writes:
> Michael, in modifying autorevert-tests.el, at the start of
> auto-revert-test02-auto-revert-deleted-file, *Messages* was narrowed,
> and then narrowed again before the call to auto-revert--wait-for-revert,
> so it looked safe to delete the first narrowing instead of replacing it
> with ert-with-message-capture. Let me know if I've missed something
> there.
In autorevert-tests.el, the *Messages* buffer is narrowed systematically
prior any write-region call. I don't remember the details, but AFAIR
there were some other messages which have poisoned the tests.
I let it to you to change wherever you feel it is necessary. Tests will
show whether there are undesired side effects.
Best regards, Michael.
next prev parent reply other threads:[~2016-12-10 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 17:29 bug#25158: [PATCH] A better way for test code to access messages Gemini Lasswell
2016-12-10 19:27 ` Michael Albinus [this message]
2017-02-04 11:39 ` Eli Zaretskii
2017-02-05 13:12 ` Michael Albinus
2017-02-07 20:46 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inqrlh3p.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=25158@debbugs.gnu.org \
--cc=gazally@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).