From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#25618: 25.1.91; More precise limit for tagging expensive tests Date: Sat, 04 Feb 2017 22:42:44 +0900 Message-ID: <87inoqqdgr.fsf@calancha-pc> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486215853 29239 195.159.176.226 (4 Feb 2017 13:44:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 4 Feb 2017 13:44:13 +0000 (UTC) To: 25618@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 04 14:44:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca0dM-0007Ma-92 for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 14:44:08 +0100 Original-Received: from localhost ([::1]:39438 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca0dR-0003oR-Mb for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 08:44:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca0dL-0003oG-Ev for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 08:44:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ca0dG-0007m1-JJ for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 08:44:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57376) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ca0dG-0007lk-EC for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 08:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ca0dG-0004nL-5U for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 08:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2017 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25618 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.148621578418358 (code B ref -1); Sat, 04 Feb 2017 13:44:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Feb 2017 13:43:04 +0000 Original-Received: from localhost ([127.0.0.1]:55575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca0cK-0004m2-BX for submit@debbugs.gnu.org; Sat, 04 Feb 2017 08:43:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca0cH-0004lW-VH for submit@debbugs.gnu.org; Sat, 04 Feb 2017 08:43:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ca0cC-0007QA-0C for submit@debbugs.gnu.org; Sat, 04 Feb 2017 08:42:56 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:48209) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ca0cB-0007Pv-S9 for submit@debbugs.gnu.org; Sat, 04 Feb 2017 08:42:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca0cA-0003jQ-Gp for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 08:42:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ca0c5-0007M1-L5 for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 08:42:54 -0500 Original-Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:33881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ca0c5-0007Lq-FE for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 08:42:49 -0500 Original-Received: by mail-pf0-x22a.google.com with SMTP id e4so12661944pfg.1 for ; Sat, 04 Feb 2017 05:42:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=kMczpP10cXcJoG7oIek/HTFyO1UanWC8saxFXU279Bg=; b=mhoxQSZbAweudTvMBx60b/5xSdWns4ArME+stBjZ+qaQAR3mw/rUWd7gSF990y8uRd sGYi932iRMSWSxK2qB375wWg7QWw2A0sS8FBk/l1AnrnYsRygUsC+w79YgmilbBZY6sH wuD/BV1wbU54zAgdqg/TcFeCmC5Xz0TJlMy6HrrCk3dBEfQofcCI9jh8LRigDTr9RT6y qeKAZdRG7b//N5P6KRVvPKM8dS0KKIMiI9x+GhYbvMvHlb2vGZHPssShdJVOv7VWsWgZ u16CM/Ipe1u67d0nGtJvkful19hKdrgDutQCbhrjfRX9qasBEe3JeAXD1u3PZEr2h3cJ z7hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=kMczpP10cXcJoG7oIek/HTFyO1UanWC8saxFXU279Bg=; b=Bg7QGh8vbZv/aE2mGSrOgRu7ZRxPqexqeRiWQbZ/dUPQLpmIa35osoTENBxNCf4Dns HEHGIIzIYZt5gv5DioArZaMUqHssodwZZegxHdjpuU+KB6t2m8meDPcPzzZ+OC4xpJkO YnIZWCeD5GupR2A7EKE64DFw0l6b7TbvqECuGm7mMyJAvLAFdPILKcP8VwOH/tcMe1ex pI/ZJKdqQdpKthBP3yA5Eya6gyBeMQ7FQe1XJ5HblbkBFtlXm5QyQ36rpKzrHWRM1gBc c9AWTj+nP6FMtYYBNNpJzEU0/5aej2MjAXERp3UAsBWO65ENCqCmGAuLrcA/fivReCRF kZEw== X-Gm-Message-State: AIkVDXKU/28pG73ArItSMgpGiojPpkRAcxw9WYc2JF7H+mJsqvpHcz6gg2Fzdumnx3DH3Q== X-Received: by 10.84.224.133 with SMTP id s5mr3566367plj.130.1486215768024; Sat, 04 Feb 2017 05:42:48 -0800 (PST) Original-Received: from calancha-pc (104.81.147.124.dy.bbexcite.jp. [124.147.81.104]) by smtp.gmail.com with ESMTPSA id q64sm59650604pga.0.2017.02.04.05.42.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Feb 2017 05:42:47 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128949 Archived-At: Prefer set a numeric limit of seconds than using the word 'few'. For instance, in my box the test `cl-seq-test-bug24264' in test/lisp/emacs-lisp/cl-seq-tests.el takes 7 s. With an explicit numeric threshold is easier to decide whether this test must be tagged as expensive or not. In following patch i define a few as 2-3 seconds. Other people might prefer 4-5 or even higher. Please, suggest a proper value to consider a test as expensive. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From 5671609ff5120ac7572b8a103a9aeb899542d47f Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Sat, 4 Feb 2017 22:29:24 +0900 Subject: [PATCH] More precise limit for tagging expensive tests * CONTRIBUTE (Testing your changes): Tag a test as expensive when lasts longer than 2-3 seconds. --- CONTRIBUTE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTE b/CONTRIBUTE index e9a0341980..155b7ef762 100644 --- a/CONTRIBUTE +++ b/CONTRIBUTE @@ -273,7 +273,7 @@ http://www.gnu.org/software/emacs/manual/html_node/ert/ or run 'info "(ert)"' for for more information on writing and running tests. -If your test lasts longer than some few seconds, mark it in its +If your test lasts longer than 2-3 seconds, mark it in its 'ert-deftest' definition with ":tags '(:expensive-test)". To run tests on the entire Emacs tree, run "make check" from the -- 2.11.0 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.1.91.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.7) of 2017-02-04 Repository revision: 5e921112680f96d3ed94faf7dcf257e07f92d74b