unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex <agrambot@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: 27436-done@debbugs.gnu.org
Subject: bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master
Date: Sun, 25 Jun 2017 13:51:31 -0600	[thread overview]
Message-ID: <87injjlubg.fsf@lylat> (raw)
In-Reply-To: <20170625141300.GA17130@acm> (Alan Mackenzie's message of "Sun, 25 Jun 2017 14:13:01 +0000")

Alan Mackenzie <acm@muc.de> writes:

> Hello, Alex.
>
> On Wed, Jun 21, 2017 at 00:04:12 -0600, Alex wrote:
>> cc-defs has this condition to check whether or not to include cl-lib:
>
>> ======================================
>> (and (fboundp 'mapcan)
>>      (subrp (symbol-function 'mapcan)))
>> ======================================
>
>> As of 466ee1b3ea, Emacs now has a built in mapcan, so the above returns
>> true.
>
> Yes.  Thanks for taking the trouble to report this bug.
>
> I've committed a fix to master.  I'd be grateful if you would confirm it
> fixes the problem properly, or tell me what's not quite right.
>
>> Other code in cc-defs.el uses (featurep 'xemacs). Is there a reason why
>> it can't be used here?
>
> CC Mode has always favoured testing features rather than version numbers
> and the the base (X)Emacs, so that if a tested feature becomes or ceases
> to be available, CC Mode should pick that up automatically.  That is
> illustrated by the current case, just that here the actual test used was
> suboptimal.  Hopefully it is now OK.

Hello, Alan.

Thanks for the explanation and fix; I can confirm that the problem is
fixed in master. I'll close this bug.





      parent reply	other threads:[~2017-06-25 19:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  6:04 bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master Alex
2017-06-25 14:13 ` Alan Mackenzie
     [not found] ` <20170625141300.GA17130@acm>
2017-06-25 19:51   ` Alex [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87injjlubg.fsf@lylat \
    --to=agrambot@gmail.com \
    --cc=27436-done@debbugs.gnu.org \
    --cc=acm@muc.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).