From: daimrod@omecha.info (Grégoire Jadi)
To: 23994@debbugs.gnu.org
Subject: bug#23994: [PATCH] Fix cl-defmethod indent with qualifier (Bug##23994) (Was: 25.1.50; cl-defmethod with qualifier indented incorrectly)
Date: Tue, 25 Jul 2017 10:00:37 +0200 [thread overview]
Message-ID: <87inihndy2.fsf@omecha.info> (raw)
In-Reply-To: <87vb06j3qg.fsf@ericabrahamsen.net>
[-- Attachment #1: Type: text/plain, Size: 147 bytes --]
Hello,
I've been bitten by this bug as well on 25.2.1.
I've attached a patch to fix it.
Best,
PS: I've FSF copyright assignment number #793656
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-cl-defmethod-indent-with-qualifier.patch --]
[-- Type: text/x-patch, Size: 1006 bytes --]
From 7aed0320d9471138c9ad6652c37fe05c563f9af8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= <gjadi@omecha.info>
Date: Tue, 25 Jul 2017 09:46:32 +0200
Subject: [PATCH] Fix cl-defmethod indent with qualifier (Bug##23994)
lisp/emacs-lisp/cl-generic.el(cl-defmethod): Indent `cl-defmethod'
like a def construct.
---
lisp/emacs-lisp/cl-generic.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
index 6a4ee47ac2..1d29082c62 100644
--- a/lisp/emacs-lisp/cl-generic.el
+++ b/lisp/emacs-lisp/cl-generic.el
@@ -409,7 +409,7 @@ cl-defmethod
\(and can be extended) by the various methods of `cl-generic-generalizers'.
\(fn NAME [QUALIFIER] ARGS &rest [DOCSTRING] BODY)"
- (declare (doc-string 3) (indent 2)
+ (declare (doc-string 3) (indent defun)
(debug
(&define ; this means we are defining something
[&or name ("setf" name :name setf)]
--
2.13.3
next prev parent reply other threads:[~2017-07-25 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 15:55 bug#23994: 25.1.50; cl-defmethod with qualifier indented incorrectly Eric Abrahamsen
2017-07-25 8:00 ` Grégoire Jadi [this message]
2017-07-25 8:02 ` bug#23994: [PATCH] Fix cl-defmethod indent with qualifier (Bug##23994) Grégoire Jadi
2017-07-26 15:53 ` bug#23994: [PATCH] Fix cl-defmethod indent with qualifier (Bug##23994) (Was: 25.1.50; cl-defmethod with qualifier indented incorrectly) Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inihndy2.fsf@omecha.info \
--to=daimrod@omecha.info \
--cc=23994@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).