unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#27959: 26.0.50; File renaming fails on sshfs
@ 2017-08-04 21:38 Lars Ingebrigtsen
  2017-08-05  8:24 ` Philipp Stephani
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2017-08-04 21:38 UTC (permalink / raw)
  To: 27959


/tv is mounted via sshfs.

(rename-file "/tv/a.foo" "/tv/b.foo")

Debugger entered--Lisp error: (file-error "Renaming" "Invalid argument" "/tv/a.foo" "/tv/b.foo")
  rename-file("/tv/a.foo" "/tv/b.foo")
  eval((rename-file "/tv/a.foo" "/tv/b.foo") nil)
  eval-expression((rename-file "/tv/a.foo" "/tv/b.foo") nil nil 127)
  funcall-interactively(eval-expression (rename-file "/tv/a.foo" "/tv/b.foo") nil nil 127)
  call-interactively(eval-expression nil nil)
  command-execute(eval-expression)

But if I say

larsi@amy:~$ mv /tv/a.foo /tv/b.foo

on the same machine, it works fine.  So ... where is the "Invalid
argument" coming from?

Renaming on non-sshfs file systems works fine in Emacs.


In GNU Emacs 26.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2017-08-02 built on amy
Repository revision: fe80d58ca4ead89e8887aa726482694888a8ef7f
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description:	Ubuntu 17.04






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#27959: 26.0.50; File renaming fails on sshfs
  2017-08-04 21:38 bug#27959: 26.0.50; File renaming fails on sshfs Lars Ingebrigtsen
@ 2017-08-05  8:24 ` Philipp Stephani
  2017-08-05  9:24   ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Philipp Stephani @ 2017-08-05  8:24 UTC (permalink / raw)
  To: Lars Ingebrigtsen, 27959

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> schrieb am Fr., 4. Aug. 2017 um
23:39 Uhr:

>
> /tv is mounted via sshfs.
>
> (rename-file "/tv/a.foo" "/tv/b.foo")
>
> Debugger entered--Lisp error: (file-error "Renaming" "Invalid argument"
> "/tv/a.foo" "/tv/b.foo")
>   rename-file("/tv/a.foo" "/tv/b.foo")
>   eval((rename-file "/tv/a.foo" "/tv/b.foo") nil)
>   eval-expression((rename-file "/tv/a.foo" "/tv/b.foo") nil nil 127)
>   funcall-interactively(eval-expression (rename-file "/tv/a.foo"
> "/tv/b.foo") nil nil 127)
>   call-interactively(eval-expression nil nil)
>   command-execute(eval-expression)
>
> But if I say
>
> larsi@amy:~$ mv /tv/a.foo /tv/b.foo
>
> on the same machine, it works fine.  So ... where is the "Invalid
> argument" coming from?
>

Probably more fallout of 1f9f514e7c2ba41b0954d0141f99652f6a53a107. Does it
work if you compile without that commit (e.g. git reset --hard
1f9f514e7c2ba41b0954d0141f99652f6a53a107^ from a clean working directory)?

[-- Attachment #2: Type: text/html, Size: 1449 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#27959: 26.0.50; File renaming fails on sshfs
  2017-08-05  8:24 ` Philipp Stephani
@ 2017-08-05  9:24   ` Lars Ingebrigtsen
  2017-08-05 18:51     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2017-08-05  9:24 UTC (permalink / raw)
  To: Philipp Stephani; +Cc: 27959

Philipp Stephani <p.stephani2@gmail.com> writes:

> Probably more fallout of 1f9f514e7c2ba41b0954d0141f99652f6a53a107.
> Does it work if you compile without that commit (e.g. git reset --hard
> 1f9f514e7c2ba41b0954d0141f99652f6a53a107^ from a clean working
> directory)? 

Yes, renaming files on sshfs works again if I build after doing that git
command.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#27959: 26.0.50; File renaming fails on sshfs
  2017-08-05  9:24   ` Lars Ingebrigtsen
@ 2017-08-05 18:51     ` Lars Ingebrigtsen
  2017-08-05 20:59       ` Paul Eggert
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2017-08-05 18:51 UTC (permalink / raw)
  To: Paul Eggert; +Cc: 27959

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Philipp Stephani <p.stephani2@gmail.com> writes:
>
>> Probably more fallout of 1f9f514e7c2ba41b0954d0141f99652f6a53a107.
>> Does it work if you compile without that commit (e.g. git reset --hard
>> 1f9f514e7c2ba41b0954d0141f99652f6a53a107^ from a clean working
>> directory)? 
>
> Yes, renaming files on sshfs works again if I build after doing that git
> command.

Paul, I'm just Cc-ing you this bug report in case you didn't see it --
it relates to changes you've made recently and that makes renaming files
on certain file systems not work any more.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#27959: 26.0.50; File renaming fails on sshfs
  2017-08-05 18:51     ` Lars Ingebrigtsen
@ 2017-08-05 20:59       ` Paul Eggert
  2017-08-05 21:09         ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggert @ 2017-08-05 20:59 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 27959

Lars Ingebrigtsen wrote:
> Paul, I'm just Cc-ing you this bug report in case you didn't see it --
> it relates to changes you've made recently and that makes renaming files
> on certain file systems not work any more.

Thanks, I hadn't seen that bug report. I think that I fixed that bug in commit 
ddc1ff58dec92a782b233d97a254fc41c1c887eb dated Thu Aug 3 16:18:45 2017 -0700, so 
please try pulling from master and rebuilding.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#27959: 26.0.50; File renaming fails on sshfs
  2017-08-05 20:59       ` Paul Eggert
@ 2017-08-05 21:09         ` Lars Ingebrigtsen
  0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2017-08-05 21:09 UTC (permalink / raw)
  To: Paul Eggert; +Cc: 27959-done

Paul Eggert <eggert@cs.ucla.edu> writes:

> Thanks, I hadn't seen that bug report. I think that I fixed that bug
> in commit ddc1ff58dec92a782b233d97a254fc41c1c887eb dated Thu Aug 3
> 16:18:45 2017 -0700, so please try pulling from master and rebuilding.

Ah, thanks; this does indeed seem to be fixed now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-08-05 21:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-04 21:38 bug#27959: 26.0.50; File renaming fails on sshfs Lars Ingebrigtsen
2017-08-05  8:24 ` Philipp Stephani
2017-08-05  9:24   ` Lars Ingebrigtsen
2017-08-05 18:51     ` Lars Ingebrigtsen
2017-08-05 20:59       ` Paul Eggert
2017-08-05 21:09         ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).