* bug#29147: 27.0.50; gnutls-available-p broken
@ 2017-11-04 21:53 Juri Linkov
2017-11-05 10:54 ` Robert Pluim
0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2017-11-04 21:53 UTC (permalink / raw)
To: 29147
The Emacs GnuTLS manual says that gnutls-available-p returns t
if GnuTLS is available, but really it returns nil, and I don't see
how gnutls-available-p is supposed to return a non-nil value
when HAVE_GNUTLS is defined, but HAVE_GNUTLS3 is not.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#29147: 27.0.50; gnutls-available-p broken
2017-11-04 21:53 bug#29147: 27.0.50; gnutls-available-p broken Juri Linkov
@ 2017-11-05 10:54 ` Robert Pluim
2017-11-05 15:29 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2017-11-05 10:54 UTC (permalink / raw)
To: Juri Linkov; +Cc: 29147, Ted Zlatanov
Juri Linkov <juri@linkov.net> writes:
> The Emacs GnuTLS manual says that gnutls-available-p returns t
> if GnuTLS is available, but really it returns nil, and I don't see
> how gnutls-available-p is supposed to return a non-nil value
> when HAVE_GNUTLS is defined, but HAVE_GNUTLS3 is not.
Its docstring says:
gnutls-available-p is a built-in function in `C source code'.
(gnutls-available-p)
Return list of capabilities if GnuTLS is available in this instance of Emacs.
I see that the info documentation says it returns t, so that needs
fixing.
Your point about HAVE_GNUTLS3 is valid, that's true as of commit
583995c62dd424775dda33d5134ce04bee2ae685. Ted, was that intentional?
Regards
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#29147: 27.0.50; gnutls-available-p broken
2017-11-05 10:54 ` Robert Pluim
@ 2017-11-05 15:29 ` Eli Zaretskii
2017-11-06 21:35 ` Juri Linkov
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2017-11-05 15:29 UTC (permalink / raw)
To: Robert Pluim; +Cc: 29147, tzz, juri
> From: Robert Pluim <rpluim@gmail.com>
> Date: Sun, 05 Nov 2017 11:54:57 +0100
> Cc: 29147@debbugs.gnu.org, Ted Zlatanov <tzz@lifelogs.com>
>
> Juri Linkov <juri@linkov.net> writes:
>
> > The Emacs GnuTLS manual says that gnutls-available-p returns t
> > if GnuTLS is available, but really it returns nil, and I don't see
> > how gnutls-available-p is supposed to return a non-nil value
> > when HAVE_GNUTLS is defined, but HAVE_GNUTLS3 is not.
>
> Its docstring says:
>
> gnutls-available-p is a built-in function in `C source code'.
>
> (gnutls-available-p)
>
> Return list of capabilities if GnuTLS is available in this instance of Emacs.
>
> I see that the info documentation says it returns t, so that needs
> fixing.
Not just the documentation, the code as well needs fixing.
> Your point about HAVE_GNUTLS3 is valid, that's true as of commit
> 583995c62dd424775dda33d5134ce04bee2ae685. Ted, was that intentional?
I cannot see how this could be intentional, because it makes it
impossible to distinguish between GnuTLS 2.x and no GnuTLS at all. So
I fixed this on the release branch.
If Juri (or someone else) has GnuTLS 2.x, please test and close the
bug if it is indeed fixed.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#29147: 27.0.50; gnutls-available-p broken
2017-11-05 15:29 ` Eli Zaretskii
@ 2017-11-06 21:35 ` Juri Linkov
0 siblings, 0 replies; 4+ messages in thread
From: Juri Linkov @ 2017-11-06 21:35 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 29147-done, Robert Pluim, tzz
>> > The Emacs GnuTLS manual says that gnutls-available-p returns t
>> > if GnuTLS is available, but really it returns nil, and I don't see
>> > how gnutls-available-p is supposed to return a non-nil value
>> > when HAVE_GNUTLS is defined, but HAVE_GNUTLS3 is not.
>>
>> Its docstring says:
>>
>> gnutls-available-p is a built-in function in `C source code'.
>>
>> (gnutls-available-p)
>>
>> Return list of capabilities if GnuTLS is available in this instance of Emacs.
>>
>> I see that the info documentation says it returns t, so that needs
>> fixing.
>
> Not just the documentation, the code as well needs fixing.
>
>> Your point about HAVE_GNUTLS3 is valid, that's true as of commit
>> 583995c62dd424775dda33d5134ce04bee2ae685. Ted, was that intentional?
>
> I cannot see how this could be intentional, because it makes it
> impossible to distinguish between GnuTLS 2.x and no GnuTLS at all. So
> I fixed this on the release branch.
>
> If Juri (or someone else) has GnuTLS 2.x, please test and close the
> bug if it is indeed fixed.
Thanks, with this change it works now without problems,
so I'm closing this bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-06 21:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-04 21:53 bug#29147: 27.0.50; gnutls-available-p broken Juri Linkov
2017-11-05 10:54 ` Robert Pluim
2017-11-05 15:29 ` Eli Zaretskii
2017-11-06 21:35 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).