From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 29854@debbugs.gnu.org
Subject: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows
Date: Wed, 03 Jan 2018 08:33:53 -0500 [thread overview]
Message-ID: <87incjrrr2.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87tvw3cgh9.fsf@gmail.com> (Pierre Neidhardt's message of "Wed, 03 Jan 2018 12:46:26 +0100")
Pierre Neidhardt <ambrevar@gmail.com> writes:
>> The question is then whether there is some case where using overlays is
>> necessary, or is it just a pessimization? For reference, I took the
>> text property using definition from man.el (so it at least works for
>> that case):
>
> Any idea what the original intent was?
> I can't seem to see why an overlay would be needed for Eshell's output.
Hard to say. It might just be a case of going with ansi-color.el's
default. ansi-color-apply-on-region was changed to use overlays in [1:
0e3c1e3ea6], but it's unclear why. The commit message just says
(ansi-color-apply-on-region): Use extents or overlays instead of
text-properties.
[1: 0e3c1e3ea6]: 2001-01-09 11:38:28 +0000
(ansi-color-process-output): Use markers instead of positions for start and end of region.[...]
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0e3c1e3ea6a27e20d0252661336afe9fc84b21f5
next prev parent reply other threads:[~2018-01-03 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 10:43 bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows Pierre Neidhardt
2018-01-01 2:07 ` Noam Postavsky
2018-01-02 12:40 ` Pierre Neidhardt
2018-01-02 13:50 ` Noam Postavsky
2018-01-03 11:46 ` Pierre Neidhardt
2018-01-03 13:33 ` Noam Postavsky [this message]
2019-05-04 19:49 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87incjrrr2.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=29854@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).