From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#31846: 26.1; secrets.el can't create gnome keyring items/smtpmail.el can't get credentials from gnome keyring Date: Sat, 16 Jun 2018 12:31:55 +0200 Message-ID: <87in6jja3o.fsf@gmx.de> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1529145073 22653 195.159.176.226 (16 Jun 2018 10:31:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 10:31:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 31846@debbugs.gnu.org To: lebitso Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 16 12:31:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fU8U6-0005ib-Jv for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 12:31:06 +0200 Original-Received: from localhost ([::1]:50950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU8WD-00009W-Cx for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 06:33:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU8W1-00009Q-GQ for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 06:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fU8Vy-0001Tg-BZ for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 06:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fU8Vy-0001Sw-6p for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 06:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fU8Vx-00023h-LT for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 06:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jun 2018 10:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31846 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31846-submit@debbugs.gnu.org id=B31846.15291451277852 (code B ref 31846); Sat, 16 Jun 2018 10:33:01 +0000 Original-Received: (at 31846) by debbugs.gnu.org; 16 Jun 2018 10:32:07 +0000 Original-Received: from localhost ([127.0.0.1]:51013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fU8V4-00022Z-OH for submit@debbugs.gnu.org; Sat, 16 Jun 2018 06:32:06 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:35233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fU8V1-000224-Tx for 31846@debbugs.gnu.org; Sat, 16 Jun 2018 06:32:04 -0400 Original-Received: from detlef.gmx.de ([79.140.122.92]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MK3bN-1fTJ171N6z-001Px6; Sat, 16 Jun 2018 12:31:56 +0200 In-Reply-To: (lebitso@posteo.net's message of "Fri, 15 Jun 2018 12:19:49 +0200") X-Provags-ID: V03:K1:wT2yJ3tR6Cn2Y7lCfZWMVGb3YKOEw9UQVLHrvSWaiDD5FDmQfLg tOS8GjQI1MqyqAIGLN/83sHDBJ+uTphlCbrLIy0AE7XPbXdOx3qXQi76ME+50gS0s+vjupy kRzcrvcx3xUkBDCig/He3dQztZE/h8hZhOJ4KDRGBijXznyGtBvvJJVD7SNjoqWvT8WrOuv x1/vK3iL9Q4yVuKExhngQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:3FCzVbU+taU=:7R2iH6pfWPNuibsPaEbFEZ Eo/p9DQYIntm4vCHpMtCECkR/vNc5JZgoCByy5Bx2PVKaC3OEiYS65GQF3fVo8d2RPcFImGfo ztG03D+qLIrIg9s/dqXQ6i/5CppybQypg403noZ04bLfJmCghGt7hV0ybMbI4gofkZgzfg7Pd Wy+xdgXNmSy1tmerJRrMgG0Hn0g4P09a6UekNjEBVBwlXrUEzKNNuDwPNhJAKIt+bueLZb2Ma irI/sqmcfecs2Kpaxd2//dBuQqEEDEBQDQjmW95z31tE7OsqlZSoffitEQ6Zpf8hziz3WCAyG mHyk8in/YB3uIhuUU9nZm+kPeuoGinRaPacYxwQxR9bJKzuP4zZOYdIEsvAP3GLgWB14++IQ8 6phTMAS3xkVCPsg9i6ja0mAcoUZ2HCU4Mt23Lm7haA51B1GzCEU5m4LxxgU4YrRWppxg3I246 efa6VSE2rVShLHbUYv/WQrGatV2FpN3e+bBzcJuESnX91pjo0JktkA28yoBf1g0vvhZPO2Ztw GJTrmHOQEosbShrqIr5Hk8YmL835XlVg/OSy1oqkfM3z6bBFmhPZJ9EHImWBSxCKzApJ2P51D PIOz/Iar/6bWVP5rute2nHQgzQPfw6iHrCXTxNfn7vu6nlff+DIJLENxGWNW8BuBDHLU6gzte 5J1gU7Kk8JfGqaTwsPjVMSeShktH76GwlbrH6nT0Yr07bkVBogzJaAzCYGX4DqtEx3Pvz4nGA OESXBOR+QTHqokyvzgBeusUyJMmk2DXusTyCcj4cM9kxjAM5pKUmxabVY98= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147491 Archived-At: --=-=-= Content-Type: text/plain lebitso writes: > Hello List, Hi, > my initial problem was that I can't send mails from mu4e anymore, when I > try to it fails and gives the message > > I then found out that I can send mails if I enter the the credentials > manually instead of getting them from gnome keyring as I usually do. > So I looked into it and found there's another problem with secrets.el > that i think is related. > > I'm on Arch Linux. Other Applications can create new items in the > keyring without a problem. The only thing that I can think of that has > changed since the last time I kno this worked is the upgrade to emacs26. > The Problem does occur in the same way with emacs -Q as it does with my > full configuration. > > I have no idea what could've caused it so I'd appreciate any feedback on > whether you can reproduce this issue. Confirmed, I can reproduce it with Emacs 26. In Emacs 27.0.50, this is fixed already, by commit b3956d85c7 related to bug#29575. Since this is part of a larger rewrite of secrets.el due to a new feature, I cannot simply cherry-pick that commit from Emacs' master branch to the emacs-26 branch. IIRC, the bug was uncovered while working on the new feature, and it was fixed silently. The appended patch seems to fix the problem in the emacs-26 branch. Could you, pls, check whether it works for you? > Thanks, > L. Best regards, Michael. --=-=-= Content-Type: text/plain Content-Disposition: attachment diff --git a/lisp/net/secrets.el b/lisp/net/secrets.el index fbb0a74978..c468548316 100644 --- a/lisp/net/secrets.el +++ b/lisp/net/secrets.el @@ -612,9 +612,9 @@ secrets-search-items (error 'wrong-type-argument (cadr attributes))) (setq props (append props - (list :dict-entry - (substring (symbol-name (car attributes)) 1) - (cadr attributes))) + `((:dict-entry + ,(substring (symbol-name (car attributes)) 1) + ,(cadr attributes)))) attributes (cddr attributes))) ;; Search. The result is a list of object paths. (setq result @@ -650,9 +650,9 @@ secrets-create-item (error 'wrong-type-argument (cadr attributes))) (setq props (append props - (list :dict-entry - (substring (symbol-name (car attributes)) 1) - (cadr attributes))) + `((:dict-entry + ,(substring (symbol-name (car attributes)) 1) + ,(cadr attributes)))) attributes (cddr attributes))) ;; Create the item. (setq result --=-=-=--