From: Michael Albinus <michael.albinus@gmx.de>
To: lebitso <lebitso@posteo.net>
Cc: 31846@debbugs.gnu.org
Subject: bug#31846: 26.1; secrets.el can't create gnome keyring items/smtpmail.el can't get credentials from gnome keyring
Date: Sat, 16 Jun 2018 12:31:55 +0200 [thread overview]
Message-ID: <87in6jja3o.fsf@gmx.de> (raw)
In-Reply-To: <e2d528dbd92398fa1496ea2b79af48ed@posteo.de> (lebitso@posteo.net's message of "Fri, 15 Jun 2018 12:19:49 +0200")
[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]
lebitso <lebitso@posteo.net> writes:
> Hello List,
Hi,
> my initial problem was that I can't send mails from mu4e anymore, when I
> try to it fails and gives the message
>
> I then found out that I can send mails if I enter the the credentials
> manually instead of getting them from gnome keyring as I usually do.
> So I looked into it and found there's another problem with secrets.el
> that i think is related.
>
> I'm on Arch Linux. Other Applications can create new items in the
> keyring without a problem. The only thing that I can think of that has
> changed since the last time I kno this worked is the upgrade to emacs26.
> The Problem does occur in the same way with emacs -Q as it does with my
> full configuration.
>
> I have no idea what could've caused it so I'd appreciate any feedback on
> whether you can reproduce this issue.
Confirmed, I can reproduce it with Emacs 26.
In Emacs 27.0.50, this is fixed already, by commit b3956d85c7 related to
bug#29575. Since this is part of a larger rewrite of secrets.el due to a
new feature, I cannot simply cherry-pick that commit from Emacs' master
branch to the emacs-26 branch. IIRC, the bug was uncovered while working
on the new feature, and it was fixed silently.
The appended patch seems to fix the problem in the emacs-26
branch. Could you, pls, check whether it works for you?
> Thanks,
> L.
Best regards, Michael.
[-- Attachment #2: Type: text/plain, Size: 1027 bytes --]
diff --git a/lisp/net/secrets.el b/lisp/net/secrets.el
index fbb0a74978..c468548316 100644
--- a/lisp/net/secrets.el
+++ b/lisp/net/secrets.el
@@ -612,9 +612,9 @@ secrets-search-items
(error 'wrong-type-argument (cadr attributes)))
(setq props (append
props
- (list :dict-entry
- (substring (symbol-name (car attributes)) 1)
- (cadr attributes)))
+ `((:dict-entry
+ ,(substring (symbol-name (car attributes)) 1)
+ ,(cadr attributes))))
attributes (cddr attributes)))
;; Search. The result is a list of object paths.
(setq result
@@ -650,9 +650,9 @@ secrets-create-item
(error 'wrong-type-argument (cadr attributes)))
(setq props (append
props
- (list :dict-entry
- (substring (symbol-name (car attributes)) 1)
- (cadr attributes)))
+ `((:dict-entry
+ ,(substring (symbol-name (car attributes)) 1)
+ ,(cadr attributes))))
attributes (cddr attributes)))
;; Create the item.
(setq result
next prev parent reply other threads:[~2018-06-16 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 10:19 bug#31846: 26.1; secrets.el can't create gnome keyring items/smtpmail.el can't get credentials from gnome keyring lebitso
2018-06-16 10:31 ` Michael Albinus [this message]
2018-06-16 13:00 ` Lukas Woell
2018-06-16 14:07 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in6jja3o.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=31846@debbugs.gnu.org \
--cc=lebitso@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).