From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Mon, 04 Feb 2019 18:05:39 -0800 Message-ID: <87imxzxa4s.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="34589"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: 33653@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 05 03:06:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqq7l-0008qz-V1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Feb 2019 03:06:10 +0100 Original-Received: from localhost ([127.0.0.1]:52625 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqq7k-0004N8-SK for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2019 21:06:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqq7e-0004Mq-Uw for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 21:06:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqq7e-0002PS-At for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 21:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60670) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqq7e-0002PD-66 for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 21:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gqq7d-00018g-Nk for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 21:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2019 02:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33653 X-GNU-PR-Package: emacs Original-Received: via spool by 33653-submit@debbugs.gnu.org id=B33653.15493323474354 (code B ref 33653); Tue, 05 Feb 2019 02:06:01 +0000 Original-Received: (at 33653) by debbugs.gnu.org; 5 Feb 2019 02:05:47 +0000 Original-Received: from localhost ([127.0.0.1]:59951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqq7O-000189-UZ for submit@debbugs.gnu.org; Mon, 04 Feb 2019 21:05:47 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:49793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqq7M-000180-Np for 33653@debbugs.gnu.org; Mon, 04 Feb 2019 21:05:45 -0500 Original-Received: from localhost (c-73-97-148-38.hsd1.wa.comcast.net [73.97.148.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id CD3203F042; Tue, 5 Feb 2019 02:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1549332341; bh=lNwGU3KORoazAtgYqPk9gKHIZMAgCh6QTstM7bm4zWg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=zP5HV7nKUFSwy3KcFhr2KZW0H8bugzJd1KwG3wkfsVpWPWmQE/hlid9ErOwC5Ed6l SylB9IaEVATcnR0y0I2PahQklWtbBXTHhc5BS14O/uHNesUEhiJzdTH2/+1IxCR2Mg H08f/cmIjuNkW1TaiqDQZDZwHezhhsiwAOQZeJW0= In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 11 Dec 2018 20:23:33 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155105 Archived-At: On 12/11/18 20:23 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >>> Here's the next thing: turning Gnus' obarrays-as-hash-tables into real >>> hash tables. Gnus currently stores information about groups by coercing >>> group names to unibyte, interning them in custom obarrays, and then >>> setting their symbol-value to whatever value needs to be stored. I think >>> all this was written before Emacs had actual hash tables. >> >> Also hounding Lars for his opinion... > > Using real hash tables sounds nice, if there's no negative performance > impact. I've pushed another commit to scratch/gnus-hashtables, fixing a small bug in gnus-bklg.el. Otherwise, I've been using this branch for a couple months now, with no ill effects. I guess what I'd like to do is squash the first commit with the third (the changes that actually implement the hash tables), but leave the second aside for now (the one that stops doing internal encoding/decoding). That ought to be done eventually, but I'll need more time to figure it out, and would like to get more exposure for this refactoring in the meantime. Eric