From: Alex <agrambot@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 35179@debbugs.gnu.org
Subject: bug#35179: [PATCH] Plug memory leak in GTK x-display-monitor-attributes-list
Date: Sun, 07 Apr 2019 12:52:45 -0600 [thread overview]
Message-ID: <87imvptzpe.fsf@gmail.com> (raw)
In-Reply-To: <83sgut8yn3.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 Apr 2019 21:21:20 +0300")
close 35179
quit
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Alex <agrambot@gmail.com>
>> Cc: 35179@debbugs.gnu.org
>> Date: Sun, 07 Apr 2019 11:44:54 -0600
>>
>> Whoops, I forgot to add a closing parenthesis...
>
> Thanks. This variant is fine with me, but since we use xfree to free
> the name, I think we should use xstrdup, not g_strdup, to copy it, as
> the latter is documented to need g_free to free the storage.
Okay, I pushed it as a35e06bbe2. I also added in a GTK version check
since `name' isn't used if !GTK_CHECK_VERSION(2, 14, 0).
prev parent reply other threads:[~2019-04-07 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 5:16 bug#35179: [PATCH] Plug memory leak in GTK x-display-monitor-attributes-list Alex
2019-04-07 6:37 ` Eli Zaretskii
2019-04-07 14:51 ` Alex
2019-04-07 16:32 ` Eli Zaretskii
2019-04-07 17:34 ` Alex
2019-04-07 17:44 ` Alex
2019-04-07 18:21 ` Eli Zaretskii
2019-04-07 18:52 ` Alex [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imvptzpe.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=35179@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).