From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) Date: Tue, 09 Apr 2019 20:03:17 -0400 Message-ID: <87imvmbube.fsf@gmail.com> References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="232882"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) Cc: 34776@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 10 02:04:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hE0iq-000yPu-2t for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Apr 2019 02:04:12 +0200 Original-Received: from localhost ([127.0.0.1]:50882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE0ip-0001bR-2v for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 20:04:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE0ih-0001aY-Pn for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 20:04:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE0ig-0005hN-Pq for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 20:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38628) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hE0ig-0005gI-JX for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 20:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hE0ig-0007KD-6E for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 20:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Apr 2019 00:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34776 X-GNU-PR-Package: emacs Original-Received: via spool by 34776-submit@debbugs.gnu.org id=B34776.155485460828112 (code B ref 34776); Wed, 10 Apr 2019 00:04:02 +0000 Original-Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 00:03:28 +0000 Original-Received: from localhost ([127.0.0.1]:52172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE0i8-0007JL-0c for submit@debbugs.gnu.org; Tue, 09 Apr 2019 20:03:28 -0400 Original-Received: from mail-qk1-f176.google.com ([209.85.222.176]:39186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE0i5-0007J7-C1 for 34776@debbugs.gnu.org; Tue, 09 Apr 2019 20:03:26 -0400 Original-Received: by mail-qk1-f176.google.com with SMTP id c189so154222qke.6 for <34776@debbugs.gnu.org>; Tue, 09 Apr 2019 17:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wzDi3CCn9qpRK5G2QEyVYCFLkZHWccr6HUjEVkmxTKE=; b=DNn8hAUYpd4FEKlGAdYBwq0PHfTkDP/BG8Ed9DTMIhIV+BEBAm71Gr8/OBCaHbgkDp RD0QfW0P1B/c8E7sYcDTB+jZu23eEGaMFGeVbVCRKujGjhnQYaAOPVEzNv+ldBagl7Jz NBijeptWyELdXaejuD1JRDybqzR+tPN9PuaUYZQV9AZXj9GLyytO3XqxSTeLAkNWv57A hgli5w0ciTmsXA/nPMbBVXEo6RbcgYS1OfH+O7FazXXFf42PxZy/DXbWcwy0tg6vGKiR 3qS2GcyikDQ3ngPMaxZ4BTfMuzs4tXIX6UCCKicWsrCpvnqwQPGp23L1/VkO94SyUhyG mIGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wzDi3CCn9qpRK5G2QEyVYCFLkZHWccr6HUjEVkmxTKE=; b=rJ4m68HEixqXU4/mHm5y4nSVc0LYJtm7nzT2CtsSQbf0eITQnU9U6DGQwZCpn9+aVx OrqninNumgmw68T/PZQEc5j6jbbFb5WWieTzgMaILEXGD1znrGV3nrH+FsammV+kl1IK vuIfHU9iBErBkw+/Of4dM/JBJgH+c2KZ1/XTyBUqlUSe1gV1EciWyJN1aJUkNtwLx1dU 0gokUQyNyy9/jazlLjhhqM9cjVzvvbQOp6i/jHQKSIltnOajwVi94d9Pi+UwQW4YjIan B3OOMaU9yLpZSVmv61DR7SJOFMIpCyp6ipXDg5sDFm8ZsTS6oEJOZOTGN4N8947cVCaI tiZg== X-Gm-Message-State: APjAAAVjUnm6946+F+0+1qbx5gMAG/z8jMpWQEX1W+EOgNJsn6Ahq+6Z mt5WoWC2cn+7J2tzeoYF/IlZKRIk X-Google-Smtp-Source: APXvYqxmvYsw8RpjiCD7kYTYuZrVFZi6lWEJ3mzOtIe2d0sLv4x34s2HQj8cfz3UrSN5N1pSBC/www== X-Received: by 2002:ae9:e40f:: with SMTP id q15mr30527966qkc.301.1554854599479; Tue, 09 Apr 2019 17:03:19 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g12sm21340613qki.76.2019.04.09.17.03.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 17:03:18 -0700 (PDT) In-Reply-To: <871s3a90qo.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 13 Mar 2019 09:51:11 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157439 Archived-At: Eric Abrahamsen writes: > So never mind! But I'd still like to add something like the attached, as > functions following the current docstring will raise an error. > > Eric > > diff --git a/lisp/simple.el b/lisp/simple.el > index d4ae5ebb1f..0274bdb459 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -8188,6 +8188,9 @@ choose-completion-string-functions > BUFFER - the buffer in which the choice should be inserted, > BASE-POSITION - where to insert the completion. > > +Functions should also accept and ignore a potential fourth > +argument, passed for backwards compatibility. > + Looks good to me. And it can go to emacs-26 since it's a doc fix.