From: Noam Postavsky <npostavs@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 35222@debbugs.gnu.org
Subject: bug#35222: 26.1; `read-command' documentation
Date: Thu, 11 Apr 2019 20:11:15 -0400 [thread overview]
Message-ID: <87imvk9j6k.fsf@gmail.com> (raw)
In-Reply-To: <jwvwok0xtjc.fsf-monnier+bug#35222@gnu.org> (Stefan Monnier's message of "Thu, 11 Apr 2019 14:55:47 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>>> 1. The doc string does not say what happens if DEFAULT is not provided
>>> (so `nil') and the user enters empty input. And what happens is not
>>> obvious. Please add that information to the doc string.
>> Um, can we declare the current behaviour a bug, and instead return nil
>> in this case? That matches the current doc string (i.e., return
>> DEFAULT-VALUE), and avoids the whole mess with the empty string symbol
>> which is weird and pretty useless as far as I can tell.
>
> Yes, it would seem to be more in line with the usual expected behavior.
> The caller can get the current behavior by passing ## as the DEFAULT
> argument, so there doesn't seem to be any good reason to return ## when
> DEFAULT was nil.
Since this bug is already closed, this should go Bug#35231.
next prev parent reply other threads:[~2019-04-12 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 22:13 bug#35222: 26.1; `read-command' documentation Drew Adams
2019-04-10 22:24 ` Noam Postavsky
2019-04-10 23:32 ` Drew Adams
2019-04-11 18:55 ` Stefan Monnier
2019-04-12 0:11 ` Noam Postavsky [this message]
2019-04-11 14:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imvk9j6k.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=35222@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).