From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer Date: Fri, 12 Apr 2019 13:16:41 +0100 Message-ID: <87imvjctau.fsf@tcd.ie> References: <87wok919ox.fsf@tcd.ie> <87d0m08zni.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="33678"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35141-done@debbugs.gnu.org To: Alex Murray Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 12 14:20:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEvAb-0008gj-2B for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2019 14:20:37 +0200 Original-Received: from localhost ([127.0.0.1]:35521 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEvAZ-0005Vw-NZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2019 08:20:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEv7A-00030O-Jw for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 08:17:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEv79-0004it-Hr for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 08:17:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEv79-0004iR-03 for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 08:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEv78-0001s6-Nt for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 08:17:02 -0400 Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Apr 2019 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 35141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 35141@debbugs.gnu.org, contovob@tcd.ie, murray.alex@gmail.com Original-Received: via spool by 35141-done@debbugs.gnu.org id=D35141.15550714177174 (code D ref 35141); Fri, 12 Apr 2019 12:17:02 +0000 Original-Received: (at 35141-done) by debbugs.gnu.org; 12 Apr 2019 12:16:57 +0000 Original-Received: from localhost ([127.0.0.1]:55562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEv72-0001re-Sy for submit@debbugs.gnu.org; Fri, 12 Apr 2019 08:16:57 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:38688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEv6z-0001rQ-Py for 35141-done@debbugs.gnu.org; Fri, 12 Apr 2019 08:16:54 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id d13so8144638edr.5 for <35141-done@debbugs.gnu.org>; Fri, 12 Apr 2019 05:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0NtxtMVKshdujoWQ5YjQ7GJi3Ky7acOc9WLLgwAIdMo=; b=g+LrLrzuv5ovPeVs8fUR/EkpwqnY7j/43PHKMUJ5GxMOiFqk1G7k60bdBr00JtTrRt 2J+Nv8fZPS6QQ9UAFHvj9HsJxBdqI2xkUuivQ4xHGlkYTZ84bUkx82T9T5rq0UD0QTMr HYESBQoWC2E9cin51LaOYsuDygOVFVjRDkAymJfS+etk+3k82dq1mLEkB7wCGI/qMBhF sxGDu+pbA4k9tim2/B7wpbJH/w1TlHXy6BZwAuoE9ZHXU2R0OfFhNXPqyP+3tfcPwDpr 7BHW9zMAWp1OlYin9eMcje7i+cX27oXTlZUk9pEetSwuwfm+ZTcIl5cKq7xMMu1WwutR UqfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0NtxtMVKshdujoWQ5YjQ7GJi3Ky7acOc9WLLgwAIdMo=; b=KC5wraJ9Nhy/xm2mxXrny5e0iWQ8xZb75wMWWc8xqM02VQSdV1DhFLQXm2078D1aVQ 7k+JIozjXRXufizxWryx52wmCVPgKK+ggj3goxVPWcDZrtRwvBly9Zym1CMPpy9xCnLS IrmEXvA3nj0nUgHXWI+8PVSLIrksdaH1jHq2ptdvjGsBvXmIN05xZXpehKMoI4xX2Ui4 BekKtmMrALZ/wIxuXjoSVx09533UMNWoYZwPW48WpJP5ve9P+7+ZBGtlfDtJ1ouG+LMq x6OGD0FaI2qb/25JZF0TpFI7zyC4duQKAE4xxX6vvs+ujzhwZUXEVjWTDpwdgaB25XDt yySQ== X-Gm-Message-State: APjAAAXt4zjK0Ml2AcdCMw41t5U2LPPBnDvDtvBTNHtRRdQ1NuD6+uq7 i88XLQa+NEAxQ0mk+CIAmtsY4Q== X-Google-Smtp-Source: APXvYqw9ADd9l3t8fEjjkv683k6lczJtFQUg+xkrUXw1D9FvaON+Xr5u+O2QXh1zK2ocAvd3AlBwng== X-Received: by 2002:a50:b8a2:: with SMTP id l31mr35549841ede.83.1555071407911; Fri, 12 Apr 2019 05:16:47 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id h9sm320304edw.20.2019.04.12.05.16.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 12 Apr 2019 05:16:46 -0700 (PDT) In-Reply-To: (Alex Murray's message of "Sat, 6 Apr 2019 20:22:38 +1030") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157546 Archived-At: Alex Murray writes: > Done - see attached. Thanks again for your help. > > On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios wrote: > > Otherwise LGTM, but we'll have to wait a few days to give others a > chance to comment. Thanks, pushed to master[1]. I made minor edits to the commit message to follow CONTRIBUTE guidelines and to make it slightly more accurate and less redundant. [1: 6dc4c722af]: Pop to originating erc buffer when clicking desktop notification 2019-04-12 13:08:28 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6dc4c722af4e5f9f189631638700cd1fb3cc2edb If you're interested in making further contributions, I would recommend starting the copyright assignment process. See CONTRIBUTE and (info "(emacs) Copyright Assignment") for details. Thanks, -- Basil