unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 35219@debbugs.gnu.org
Subject: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters
Date: Sun, 14 Apr 2019 19:19:44 -0700	[thread overview]
Message-ID: <87imvgnh6n.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87ftqphjet.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 10 Apr 2019 10:14:34 -0700")

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> This started showing up yesterday after recent changes in Gnus:
>>
>> To reproduce: Create an nnimap group called "Tést".  Restarting Gnus
>> will properly create the group "Tést", but Gnus will also say
>>
>> nnimap read 12k from quimby.gnus.org (initial sync of 3 groups; please wait)
>>
>> If you then quit Gnus and restart Gnus, this group will appear:
>>
>>        *: nnimap+quimby.gnus.org:T\351st
>>
>> If you try to kill it, all the groups in the buffer will disappear.
>>
>> So something went wrong during whatever the most recent group-related
>> changes were.  :-)
>
> Gaah... I've got a pile of tests in place for exactly this! Give me a
> bit and I'll try to reproduce.

Lars, would you give this a shot? I should only have been messing with
encoding for group names that were coming from symbols.

Thanks,
Eric


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: group-encoding-fix.diff --]
[-- Type: text/x-patch, Size: 862 bytes --]

diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el
index 2beb685822..606155d741 100644
--- a/lisp/gnus/gnus-start.el
+++ b/lisp/gnus/gnus-start.el
@@ -2146,14 +2146,14 @@ gnus-active-to-gnus-format
 	    (if (and (stringp (progn
 				(setq group (read cur)
 				      group
-				      (encode-coding-string
-				       (cond ((numberp group)
-					      (number-to-string group))
-					     ((symbolp group)
-					      (symbol-name group))
-					     ((stringp group)
-					      group))
-				       'latin-1))))
+				      (cond ((numberp group)
+					     (number-to-string group))
+					    ((symbolp group)
+					     (encode-coding-string
+					      (symbol-name group)
+					      'latin-1))
+					    ((stringp group)
+					     group)))))
 		     (numberp (setq max (read cur)))
 		     (numberp (setq min (read cur)))
 		     (null (progn

  reply	other threads:[~2019-04-15  2:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 13:15 bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters Lars Ingebrigtsen
2019-04-10 17:14 ` Eric Abrahamsen
2019-04-15  2:19   ` Eric Abrahamsen [this message]
2019-04-18 15:55     ` Eric Abrahamsen
2019-04-18 17:43       ` Andy Moreton
2019-04-18 19:48         ` Eric Abrahamsen
2019-04-18 20:42           ` Andy Moreton
2019-04-18 23:53             ` Eric Abrahamsen
2019-04-19  5:48               ` Katsumi Yamaoka
2019-04-19 16:14                 ` Eric Abrahamsen
2019-04-19 12:43               ` Andy Moreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imvgnh6n.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=35219@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).