From: Michael Heerdegen <michael_heerdegen@web.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 36324@debbugs.gnu.org, Davor Rotim <rotim.davor@gmail.com>
Subject: bug#36324: 27.0.50; Error in savehist-save: (wrong-type-argument listp t)
Date: Sat, 22 Jun 2019 17:29:22 +0200 [thread overview]
Message-ID: <87imsxiqp9.fsf@web.de> (raw)
In-Reply-To: <m3lfxuj76b.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 22 Jun 2019 11:33:32 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I've now reapplied the patch, but restored the t check in the hook and
> updated the comment.
Fixed for me, thanks.
> The doc string for `read-from-minibuffer' doesn't document the t value
> for HISTORY at all -- perhaps that should also be fixed?
It's also not hardcoded AFAIK. t is non-nil so Qminibuffer_history
isn't substituted in `read-from-minibuffer', and it's not listp so
`add-to-history' ignores it silently. AFAIU other values V with these
properties would also work this way but still provoke the
(wrong-type-argument listp V) error.
Having some input not recorded in a history is a useful feature. IMHO
this should be doable in an official way, and be documented.
If we don't solve this here, I can also open a new report.
Thanks,
Michael.
next prev parent reply other threads:[~2019-06-22 15:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 16:04 bug#36324: 27.0.50; Error in savehist-save: (wrong-type-argument listp t) Michael Heerdegen
2019-06-21 16:16 ` Lars Ingebrigtsen
2019-06-21 16:40 ` Michael Heerdegen
2019-06-21 16:50 ` Lars Ingebrigtsen
2019-06-21 17:05 ` Michael Heerdegen
2019-06-21 19:22 ` Davor Rotim
2019-06-21 23:23 ` Michael Heerdegen
2019-06-22 2:35 ` Michael Heerdegen
2019-06-22 9:33 ` Lars Ingebrigtsen
2019-06-22 15:29 ` Michael Heerdegen [this message]
2019-06-22 17:41 ` Noam Postavsky
2019-06-22 17:51 ` Michael Heerdegen
2019-06-23 12:01 ` Lars Ingebrigtsen
2019-06-23 15:27 ` Michael Heerdegen
2019-06-22 9:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imsxiqp9.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=36324@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rotim.davor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).