From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#34052: Acknowledgement (27.0.50; New command gnus-summary-press-button) Date: Sun, 23 Jun 2019 09:37:47 -0700 Message-ID: <87imswuujo.fsf@ericabrahamsen.net> References: <87tvidbkre.fsf@ericabrahamsen.net> <87ef8tn87g.fsf@ericabrahamsen.net> <87mui9y3qe.fsf@ericabrahamsen.net> <87zhm8uxnz.fsf@ericabrahamsen.net> <87r27kuwau.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109277"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34052@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 23 18:38:39 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf5Vn-000SAE-Ar for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 18:38:39 +0200 Original-Received: from localhost ([::1]:45694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf5Ve-0003gm-IR for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 12:38:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57203) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf5VG-0003gQ-0p for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 12:38:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf5VE-0002BL-4r for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 12:38:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40777) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hf5VC-00029G-87 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 12:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hf5VC-0002mA-49 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 12:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2019 16:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34052 X-GNU-PR-Package: emacs Original-Received: via spool by 34052-submit@debbugs.gnu.org id=B34052.156130788110663 (code B ref 34052); Sun, 23 Jun 2019 16:38:02 +0000 Original-Received: (at 34052) by debbugs.gnu.org; 23 Jun 2019 16:38:01 +0000 Original-Received: from localhost ([127.0.0.1]:54321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf5VA-0002lv-TY for submit@debbugs.gnu.org; Sun, 23 Jun 2019 12:38:01 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:47974 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf5V9-0002le-Gl for 34052@debbugs.gnu.org; Sun, 23 Jun 2019 12:37:59 -0400 Original-Received: from localhost (unknown [172.92.212.120]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 54376FA648; Sun, 23 Jun 2019 16:37:53 +0000 (UTC) In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 23 Jun 2019 18:17:46 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161127 Archived-At: On 06/23/19 18:17 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> The problem is, there are 'gnus-string properties that just look like >> "larsi@gnus.org", ie no scheme at all. I suppose we could just drop >> anything that doesn't look like "`[a-z]+://"... > > Oh, I didn't quite get what you were saying about `gnus-string' and > `shr-url'. > > In my Gnus buffers, the URLs all have `shr-url' on them: > > (text-property-search-forward 'gnus-string) > => nil > > in an HTML article that has links... > > (text-property-search-forward 'shr-url) > => #s(prop-match 202 206 "http://9gag.com/gag/av8Kj8n") Yeah, I'm just viewing the plain text. We'll want to support both plain and html versions, so I think scanning for both properties is still desirable. What do you think about just dropping scheme-less URLs?