From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36501: 26.2; (elisp) `Defining Minor Modes' Date: Mon, 08 Jul 2019 22:31:41 +0200 Message-ID: <87imsc2rpu.fsf@mouse.gnus.org> References: <840640b2-bc37-4f56-b16e-0622321cb764@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="52995"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36501@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 08 22:39:40 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkaQF-000DZq-Rz for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 22:39:39 +0200 Original-Received: from localhost ([::1]:44584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkaJt-0006sw-Im for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 16:33:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51218) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkaIv-0006Oj-6h for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 16:32:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkaIt-0007Ec-9c for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 16:32:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50849) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkaIs-0007E9-08 for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 16:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hkaIr-0007Ka-Sw for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 16:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2019 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36501 X-GNU-PR-Package: emacs Original-Received: via spool by 36501-submit@debbugs.gnu.org id=B36501.156261790928145 (code B ref 36501); Mon, 08 Jul 2019 20:32:01 +0000 Original-Received: (at 36501) by debbugs.gnu.org; 8 Jul 2019 20:31:49 +0000 Original-Received: from localhost ([127.0.0.1]:59667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkaIf-0007Jt-Dt for submit@debbugs.gnu.org; Mon, 08 Jul 2019 16:31:49 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:33108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkaId-0007Jj-Oo for 36501@debbugs.gnu.org; Mon, 08 Jul 2019 16:31:48 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkaIY-0004yQ-3u; Mon, 08 Jul 2019 22:31:44 +0200 In-Reply-To: <840640b2-bc37-4f56-b16e-0622321cb764@default> (Drew Adams's message of "Thu, 4 Jul 2019 08:33:07 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162359 Archived-At: Drew Adams writes: > But this doc says: > > It puts the variable 'hungry-mode' into custom group 'hunger'. > > Does that happen? Even if I define a `hunger' group before evaluating > those `define-minor-mode' sexps I don't see that `M-x customize-group' > gets you to variable `hungry-mode'. But I didn't test much, e.g. with > different `defgroup' definitions for group `hungry'. I tested a bit, and I think you're right. > My guess is that (1) `:group 'hunger' should be removed from the > examples and (2) the doc should not say that variable `hungry-mode' > is put "into custom group `hunger'. It should not give the impression > that var `hungry-mode' is a user option. I've now done so. > I also think it's not so important to show two full examples for the > buffer-local mode, and it might be good to show an example for a global > mode - perhaps even two: (1) using `define-minor-mode' and (2) using > `define-globalized-minor-mode'. The two examples are demonstrations of the short, non-explicit form and the longer, explicit forms, so I think that's useful. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no