From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 36501@debbugs.gnu.org
Subject: bug#36501: 26.2; (elisp) `Defining Minor Modes'
Date: Mon, 08 Jul 2019 22:31:41 +0200 [thread overview]
Message-ID: <87imsc2rpu.fsf@mouse.gnus.org> (raw)
In-Reply-To: <840640b2-bc37-4f56-b16e-0622321cb764@default> (Drew Adams's message of "Thu, 4 Jul 2019 08:33:07 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> But this doc says:
>
> It puts the variable 'hungry-mode' into custom group 'hunger'.
>
> Does that happen? Even if I define a `hunger' group before evaluating
> those `define-minor-mode' sexps I don't see that `M-x customize-group'
> gets you to variable `hungry-mode'. But I didn't test much, e.g. with
> different `defgroup' definitions for group `hungry'.
I tested a bit, and I think you're right.
> My guess is that (1) `:group 'hunger' should be removed from the
> examples and (2) the doc should not say that variable `hungry-mode'
> is put "into custom group `hunger'. It should not give the impression
> that var `hungry-mode' is a user option.
I've now done so.
> I also think it's not so important to show two full examples for the
> buffer-local mode, and it might be good to show an example for a global
> mode - perhaps even two: (1) using `define-minor-mode' and (2) using
> `define-globalized-minor-mode'.
The two examples are demonstrations of the short, non-explicit form and
the longer, explicit forms, so I think that's useful.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-07-08 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 15:33 bug#36501: 26.2; (elisp) `Defining Minor Modes' Drew Adams
2019-07-08 20:31 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imsc2rpu.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=36501@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).