From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#29499: 25.3; bounds-of-thing-at-point for nested s-expressions? Date: Sun, 14 Jul 2019 20:42:52 +0200 Message-ID: <87ims4wj83.fsf@mouse.gnus.org> References: <2531AEF4-EEAD-467E-A598-6621696E0CC1@fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="222351"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 29499@debbugs.gnu.org To: James Nguyen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 14 20:43:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmjSo-000vjK-Bq for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Jul 2019 20:43:10 +0200 Original-Received: from localhost ([::1]:33734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmjSm-0000XD-K2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Jul 2019 14:43:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54020) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmjSi-0000X1-TF for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 14:43:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmjSg-0002GG-U4 for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 14:43:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmjSg-0002G5-LD for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 14:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmjSg-0003sF-IN for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 14:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jul 2019 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29499 X-GNU-PR-Package: emacs Original-Received: via spool by 29499-submit@debbugs.gnu.org id=B29499.156312977814881 (code B ref 29499); Sun, 14 Jul 2019 18:43:02 +0000 Original-Received: (at 29499) by debbugs.gnu.org; 14 Jul 2019 18:42:58 +0000 Original-Received: from localhost ([127.0.0.1]:45967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmjSc-0003rx-8v for submit@debbugs.gnu.org; Sun, 14 Jul 2019 14:42:58 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmjSb-0003rl-9Z for 29499@debbugs.gnu.org; Sun, 14 Jul 2019 14:42:57 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmjSW-0004u1-Ov; Sun, 14 Jul 2019 20:42:55 +0200 In-Reply-To: <2531AEF4-EEAD-467E-A598-6621696E0CC1@fastmail.com> (James Nguyen's message of "Tue, 28 Nov 2017 23:54:17 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163028 Archived-At: James Nguyen writes: > I=E2=80=99m curious if this is expected? > > ;; (bounds-of-thing-at-point =E2=80=98sexp) > > Cursor is after ending paren of line. > > (+ 1 1) ;; M-: (bounds-of-thing-at-point =E2=80=98sexp) -> returns (x . y) > > (+ 1 1 > (+ 1 1) ;; M-: (bounds-of-thing-at-point =E2=80=98sexp) -> returns nil > ) The problem is that thingatpt wants to go to the end of the current sexp, and uses forward-sexp for that. The amusing thing about forward-sexp is that it won't error if there's nothing to advance to (like at the end of a buffer), but if it hits a ")" immediately, it signals an error, making bounds-of-thing-at-point return nil. The patch below fixes the problem, but I'm not very familiar with the thingatpt code. Does anybody think this makes sense? diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el index 60a20e2d18..319f4b2cf8 100644 --- a/lisp/thingatpt.el +++ b/lisp/thingatpt.el @@ -194,7 +194,9 @@ thing-at-point--end-of-sexp (if (or (eq char-syntax ?\)) (and (eq char-syntax ?\") (nth 3 (syntax-ppss)))) (forward-char 1) - (forward-sexp 1)))) + (condition-case _ + (forward-sexp 1) + (scan-error nil))))) =20 (define-obsolete-function-alias 'end-of-sexp 'thing-at-point--end-of-sexp "25.1" --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no