From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters Date: Sat, 27 Jul 2019 23:03:27 +0100 Message-ID: <87imrn16fk.fsf@tcd.ie> References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87h88cvpkj.fsf_-_@gmail.com> <87imsinbmr.fsf_-_@gmail.com> <87y313z3tp.fsf@gmail.com> <83wog3lo5c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="151338"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec , 35564@debbugs.gnu.org, npostavs@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 00:04:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrUnO-000dDQ-M2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 00:04:06 +0200 Original-Received: from localhost ([::1]:47478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrUnN-0000vT-Jg for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 18:04:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60476) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrUnL-0000v8-7d for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 18:04:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrUnK-0000PZ-D0 for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 18:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36707) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrUnK-0000PQ-9l for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 18:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrUnK-0002Km-2P for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 18:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2019 22:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.15642650178938 (code B ref 35564); Sat, 27 Jul 2019 22:04:02 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 27 Jul 2019 22:03:37 +0000 Original-Received: from localhost ([127.0.0.1]:45528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrUmv-0002K6-B0 for submit@debbugs.gnu.org; Sat, 27 Jul 2019 18:03:37 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:35564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrUmt-0002Jr-6F for 35564@debbugs.gnu.org; Sat, 27 Jul 2019 18:03:35 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id y4so57888739wrm.2 for <35564@debbugs.gnu.org>; Sat, 27 Jul 2019 15:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=OmlGYtC7hF9thftNtcwEbyLaAkL3m5QM4ohsFra/T0E=; b=Ca4bQ7/v0YH+rX7GLxlWBR0fEnfW07Td5865WyfNOXlUxp8iYBY8GDj4br/zJsSU+e lemGtb/al6WngoiNOQP7Q0r4ImZRM1x9leXkXLg2bHjs2p6o2pJCMk8rHI/Ba2stTvoX OS6Y7tLvUBBU3vG7XfsunrwlXls2Vw4D5NJEAJvMgJHYwCtm+0dMRo8deOMHz6k34Scb GpdAVp/PYPHjSRTzZbO1Y1BeoGuUijrBmpkN9H5oQfvPKgsVaLCAKolbyW0IHEVGm8iP xzLTbWWymEal13LaaWeewo4oEG23Jpff6fRbk4iWfJv/DOm+X5Fkm5gfDQQcgqNctY8p lzmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=OmlGYtC7hF9thftNtcwEbyLaAkL3m5QM4ohsFra/T0E=; b=kLtAip63zcJKFNGv7sHUlj3Af8wavv4OVB1X0eCIOrxksBD55Ux31YcLN3P3AJvt4a kyI1I4qp37lJOG/ig21S2Zemg3M0UwIe3ZAhbujEclrc03AjMJQeQDYO2LUaJt63hs9+ yKcPzgVdBVhhM8eXjSAzS+mtvTMQkUz7y/+792HS9Y7Fo8NbI/i/GfvkhtJPHxMHijwh 8ShYhxP6UUJ6v1EvGGKQ15dGP8NxSExdS4+oTF5fsA+fHh7LYNfJ+VHR+nlhfvlLLimp nUg9EFzYEnj4uN/NiTZFGHcP07+9h1ld/NVkWJOt0Rhyd//+mk8j09utRxJpKUwvb4q6 q/VA== X-Gm-Message-State: APjAAAWa1oQxwIOp2KQl8/b7d7c+owsgn34Y/GxSMDcMbAXycK6sAGY3 I6rOHYnGExyP22fJs/prm81COw== X-Google-Smtp-Source: APXvYqxGru7mDzqf28He2x0Mg5x14UOju1tE512jOBMUsOJ/V6bc74k1cgvwjvBci42346/8vRo9qw== X-Received: by 2002:a5d:4f01:: with SMTP id c1mr28763092wru.43.1564265009374; Sat, 27 Jul 2019 15:03:29 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id f192sm60235819wmg.30.2019.07.27.15.03.28 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 27 Jul 2019 15:03:28 -0700 (PDT) In-Reply-To: <83wog3lo5c.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jul 2019 14:20:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163915 Archived-At: Eli Zaretskii writes: > Any more comments, anyone? Just a couple of very minor questions from me: K=C3=A9vin Le Gouguec writes: > -(defun dired--no-subst-prompt (char-positions command) > +(defun dired--mark-positions (positions) > + (let ((markers (make-string > + (1+ (apply #'max positions)) Is POSITIONS guaranteed to be non-nil? (The max function takes at least one argument.) > Subject: [PATCH 6/6] Simplify highlighting assertions > > * test/lisp/dired-aux-tests.el (dired-test--check-highlighting): > New function. > (dired-test-highlight-metachar): Use it. Will this simplification hinder debugging of test failures? I don't have an opinion on the proposed change, it's just something to consider. > Again, thank you for your patience and your reviews. Thank you for working on this, --=20 Basil