From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37344: rcirc: nil gets interpreted as a nickname Date: Fri, 20 Sep 2019 20:33:18 +0200 Message-ID: <87impm95sh.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="108694"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: =?UTF-8?Q?Na=C3=AFm?= Favier , 37344@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 20 20:34:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBNjZ-000S9D-WA for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 20:34:22 +0200 Original-Received: from localhost ([::1]:34598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBNjY-0001fy-MA for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 14:34:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51076) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBNjJ-0001dL-33 for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 14:34:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBNjH-00063T-67 for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 14:34:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49664) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBNjG-00063E-3m for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 14:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iBNjF-0004Un-VJ for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 14:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2019 18:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37344-submit@debbugs.gnu.org id=B37344.156900440317218 (code B ref 37344); Fri, 20 Sep 2019 18:34:01 +0000 Original-Received: (at 37344) by debbugs.gnu.org; 20 Sep 2019 18:33:23 +0000 Original-Received: from localhost ([127.0.0.1]:58485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBNid-0004Te-4y for submit@debbugs.gnu.org; Fri, 20 Sep 2019 14:33:23 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:33362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBNic-0004TX-Bl for 37344@debbugs.gnu.org; Fri, 20 Sep 2019 14:33:22 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBNiY-0004aG-UI; Fri, 20 Sep 2019 20:33:21 +0200 In-Reply-To: (Leo Liu's message of "Mon, 09 Sep 2019 09:24:26 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166783 Archived-At: Leo Liu writes: > Thanks. Does the following patch fix the issue? It was confirmed that it does, so I guess you should just apply the patch, but: [...] > -(defun rcirc-cmd-me (args &optional process target) > - (rcirc-send-ctcp process target "ACTION" args)) > +(defun rcirc-cmd-me (args process target) > + (when target (rcirc-send-ctcp process target "ACTION" args))) Perhaps you should keep the &optional there to avoid changing the call signature? Somebody else may have code that calls the function with that calling convention. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no