From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#11680: flyspell should use mouse-3 instead of mouse-2 Date: Fri, 01 Nov 2019 19:21:35 +0100 Message-ID: <87imo3ihjk.fsf@skangas.se> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="174495"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 11680@debbugs.gnu.org To: Le Wang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 01 19:22:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQbYp-000jF2-Pl for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Nov 2019 19:22:12 +0100 Original-Received: from localhost ([::1]:41962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQbYo-00010E-KN for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Nov 2019 14:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50356) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQbYh-0000yO-O2 for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 14:22:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQbYg-0003x6-FG for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 14:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48274) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQbYg-0003x1-9k for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 14:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQbYg-000084-2I for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 14:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Nov 2019 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11680 X-GNU-PR-Package: emacs Original-Received: via spool by 11680-submit@debbugs.gnu.org id=B11680.1572632504452 (code B ref 11680); Fri, 01 Nov 2019 18:22:02 +0000 Original-Received: (at 11680) by debbugs.gnu.org; 1 Nov 2019 18:21:44 +0000 Original-Received: from localhost ([127.0.0.1]:57090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQbYO-00007D-Cr for submit@debbugs.gnu.org; Fri, 01 Nov 2019 14:21:44 -0400 Original-Received: from host.gofardesign.uk ([208.79.239.190]:56328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQbYM-00006x-Ru for 11680@debbugs.gnu.org; Fri, 01 Nov 2019 14:21:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9YAIKD66PDXYu94sGt5xTMNobl0YZK4lzqehrG2Kato=; b=N7gLeI6iCHzVi8Gg1xym8tTWHL 20w4MxqKfhQ7UM22dnerI+9H3FDLQhHaOrQRhshC8zH3qpuaiFVvx8Eu9YOwBfS3FaAHsTmDT7Dvg sS+VcUmzZkZd+7cfTFXdJWmEdjvYBfZBjauDSrXi3Qxab5zldaH4f23A/QXsN+wW7ZUs=; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:34874 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iQbYG-000748-SQ; Fri, 01 Nov 2019 13:21:37 -0500 In-Reply-To: (Le Wang's message of "Tue, 12 Jun 2012 20:23:54 +0800") X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170649 Archived-At: --=-=-= Content-Type: text/plain Le Wang writes: > This makes sense because it's a context menu which is mouse-3 in > modern UIs. > > See Stefan's answer here: > http://stackoverflow.com/questions/10973000/emacs-23-4-mouse-2-behaviour-on-os-x-10-7 So Stefan writes at the link: "Rather flyspell needs to be fixed to pop up its menu on mouse-3 since it's really more like a context menu. I.e. I recommend a M-x report-emacs-bug about it." I agree with this. Any objections to the attached patch? Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Move-flyspell-correct-word-to-mouse-3.patch >From f9b06855b129f4472908893d411d70b20fd0edfe Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Thu, 31 Oct 2019 02:15:56 +0100 Subject: [PATCH] Move flyspell-correct-word to mouse-3 * lisp/textmodes/flyspell.el (flyspell-mouse-map): Bind 'flyspell-correct-word' to 'mouse-3' instead of 'mouse-2'. (Bug#11680) * doc/emacs/fixit.texi (Spelling): Document it. * etc/NEWS: Announce it. --- doc/emacs/fixit.texi | 2 +- etc/NEWS | 9 +++++++++ lisp/textmodes/flyspell.el | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/doc/emacs/fixit.texi b/doc/emacs/fixit.texi index fc610583c8..90110e5b41 100644 --- a/doc/emacs/fixit.texi +++ b/doc/emacs/fixit.texi @@ -441,7 +441,7 @@ Spelling @findex flyspell-auto-correct-word @findex flyspell-correct-word-before-point When Flyspell mode highlights a word as misspelled, you can click on -it with @kbd{mouse-2} (@code{flyspell-correct-word}) to display a menu +it with @kbd{mouse-3} (@code{flyspell-correct-word}) to display a menu of possible corrections and actions. In addition, @kbd{C-.} or @kbd{@key{ESC}-@key{TAB}} (@code{flyspell-auto-correct-word}) will propose various successive corrections for the word at point, and diff --git a/etc/NEWS b/etc/NEWS index cd1e46bb87..21c118e6ae 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -2197,6 +2197,15 @@ file-local variable, you may need to update the value. *** Declare 'define-overload' and 'define-child-mode' as obsolete *** Rename several internal functions to use a ''mode-local-' prefix ++++ +** Flyspell mode + +*** Corrections and actions menu is now bound to mouse-3. +When Flyspell mode highlights a word as misspelled, you can click on +it to display a menu of possible corrections and actions. This was +previously bound to mouse-2 (usually the middle mouse button), but has +now been moved to mouse-3 (usually the right mouse button). + * New Modes and Packages in Emacs 27.1 diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el index ce788207cf..36da29b6ac 100644 --- a/lisp/textmodes/flyspell.el +++ b/lisp/textmodes/flyspell.el @@ -460,7 +460,7 @@ flyspell-prog-mode ;;*---------------------------------------------------------------------*/ (defvar flyspell-mouse-map (let ((map (make-sparse-keymap))) - (define-key map [mouse-2] 'flyspell-correct-word) + (define-key map [mouse-3] 'flyspell-correct-word) map) "Keymap for Flyspell to put on erroneous words.") -- 2.20.1 --=-=-=--