From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 7756@debbugs.gnu.org, Richard Kim <emacs18@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#7756: 24.0.50; enhancements to package.el
Date: Sat, 23 Nov 2019 14:35:43 +0100 [thread overview]
Message-ID: <87imnan2a8.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkm=ZeWo=mS_hL2q-VmTMqEbxLLM2Bdrr4s9eCzvU1yhz5w@mail.gmail.com> (Stefan Kangas's message of "Sun, 15 Sep 2019 01:56:08 +0200")
Stefan Kangas <stefan@marxist.se> writes:
> - ;; FIXME: should we delete PKG-DIR if it exists?
> + (when (and (file-directory-p pkg-dir)
> + (yes-or-no-p
> + (format "Package directory already exists: `%s'. Delete it?"
> + (directory-file-name pkg-dir))))
> + (delete-directory pkg-dir 'recursive))
I'm a bit uneasy about doing a recursive deletion of the directory, even
after prompting (the developer may have put, well, anything in that
directory), so I wonder whether the right fix here is to just remove the
FIXME.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-11-23 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 18:40 bug#7756: 24.0.50; enhancements to package.el emacs18
2010-12-30 15:32 ` Stefan Monnier
2010-12-30 17:27 ` Richard Kim
2010-12-31 16:46 ` Stefan Monnier
2019-09-14 23:56 ` Stefan Kangas
2019-11-23 13:35 ` Lars Ingebrigtsen [this message]
2019-11-23 13:45 ` Eli Zaretskii
2019-11-26 15:01 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imnan2a8.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=7756@debbugs.gnu.org \
--cc=emacs18@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).