From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#39284: 27.0.60; wdired: change file permissions fails on tramp buffers Date: Sat, 25 Jan 2020 22:45:30 +0100 Message-ID: <87imkzp5vp.fsf@calancha-pc.dy.bbexcite.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="75236"; mail-complaints-to="usenet@ciao.gmane.io" To: 39284@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 25 22:46:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ivTG0-000JXL-O3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jan 2020 22:46:20 +0100 Original-Received: from localhost ([::1]:57738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivTFz-0004sX-Pb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jan 2020 16:46:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37920) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivTFj-0004na-3B for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 16:46:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivTFh-0005bX-Vx for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 16:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivTFh-0005au-TC for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 16:46:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivTFh-0006DK-RP for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 16:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jan 2020 21:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39284 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157998873923850 (code B ref -1); Sat, 25 Jan 2020 21:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Jan 2020 21:45:39 +0000 Original-Received: from localhost ([127.0.0.1]:56410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivTFK-0006CZ-R8 for submit@debbugs.gnu.org; Sat, 25 Jan 2020 16:45:39 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:48855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivTFI-0006CO-JC for submit@debbugs.gnu.org; Sat, 25 Jan 2020 16:45:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37897) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivTFH-0004hS-4r for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 16:45:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivTFF-00035T-LD for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 16:45:34 -0500 Original-Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:39426) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivTFF-000302-EW for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 16:45:33 -0500 Original-Received: by mail-wr1-x435.google.com with SMTP id y11so6350728wrt.6 for ; Sat, 25 Jan 2020 13:45:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=fGyaFbb3/9cGcQLLdxTE8Yf6u66DhG3MI0yiaIrCLwI=; b=W/tOXvgOQprm9gXfeSwGFNWrFTolVtWHNmeCVet9ge9xeWBvw/2JBTIXXqBkixvAiS dVEYFWlB3rciUDSUhTySiUISZhIMArOPThZFdOX6+iPqNVsGYDYEVkTWwqeqmCuhWvRt GhInCMOg3X+IlnxoMJ+xopbhsT5LpMBpENdl5rqBbyKyg7Tz43HJkCix50PhFS17yZDY YctWMnhSuN51YtgAUegZ5TGllwVDdmEm/74bQ4kj0ZW6BZIhD/sbhdEETw41O+TTdxYi cCqz/wK+qDyg9snMLSQtug5VewTOrudlNWbtgnlk2PinknrMyNwCK5DwDZMivU0GFr1D gI6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=fGyaFbb3/9cGcQLLdxTE8Yf6u66DhG3MI0yiaIrCLwI=; b=BWvXm8jpI67K7pKgz5ULKTQjkmKCwF5uP6mxNaae0RpbMM3NrWkLE4ZDVhr0HkOy1k GuLpQtpmShqw7hflNnnK3A1T0A8ZoQ8GwyyszLP3d9CuDmcOktdCC064yJ3347nqTKtP qcvAKTAOliSM3Q37fFWVMngwPQffqSRn4NwSsL19Zejs2a8rDWUh4NDFuvAF1WGu1gN/ oGB3rCrYFBO7V0yHdSoshkjTjWsKMetVjzDKuL+G2fA9sE9Ttnbkl2IiwYtC3R9LFmoO pkOThdnxTQ+OfUzMcl7ZTcs6Ns7gMuDTwdPjYWntx7BHvZ+MjT/Vr0g9/kxkNy9zT2t3 BVog== X-Gm-Message-State: APjAAAUG0Cs7Y4at63t9cmXc9VtJEoon+Vbo2gnamP7sqL6JwT8VWLjB 6Optc9kOOqMSQIzphWR5yPzajKZw X-Google-Smtp-Source: APXvYqx+ikx2XfJ8FBpISeSE1F8gDZ1/KskLSUWpvEHZ0FeEFB6F60proP62O+v74VsXWOw7RQCwDA== X-Received: by 2002:adf:ffc7:: with SMTP id x7mr11813639wrs.159.1579988732165; Sat, 25 Jan 2020 13:45:32 -0800 (PST) Original-Received: from calancha-pc.dy.bbexcite.jp ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id v22sm11833303wml.11.2020.01.25.13.45.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jan 2020 13:45:31 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175286 Archived-At: emacs -Q /tmp -l wdired --eval '(setq wdired-allow-to-change-permissions t)' M-! touch foo RET g ;; re-visit Dired buffer as root C-x d /sudo::/tmp RET j foo RET C-x C-q ;; change the permissions for foo C-a C-f C-f C-f SPC C-c C-c ;; It fails because it passes the wrong argument to the external chmod. I propose 2 alternatives patches: 1) Assuming Bug#39280 is fixed, we just need to change 1 line ...: --8<-----------------------------cut here---------------start------------->= 8--- commit 6c139e1582645d210f051e547609b524ef6d1ef6 Author: Tino Calancha Date: Sat Jan 25 19:53:20 2020 +0100 Fix bug 39284 =20=20=20=20 * lisp/wdired.el (wdired-do-perm-changes) Call wdired-get-filename with non-nil. diff --git a/lisp/wdired.el b/lisp/wdired.el index 23dc4b9ef5..81071d40be 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -894,7 +894,7 @@ wdired-do-perm-changes (point) (next-single-property-change (point) 'end-perm))) (unless (equal perms-ori perms-new) (setq changes t) - (setq filename (wdired-get-filename nil t)) + (setq filename (wdired-get-filename 'no-dir t)) (if (=3D (length perms-new) 10) (progn (setq perm-tmp --8<-----------------------------cut here---------------end--------------->= 8--- 2) ... Or replace the call to the external chmod with built-in `set-file-mo= des' (this is what `dired-do-chmod' does): --8<-----------------------------cut here---------------start------------->= 8--- commit b2e6fc288e55919d54e27d24e478f7815d406514 Author: Tino Calancha Date: Sat Jan 25 22:27:08 2020 +0100 Fix bug 39284 =20=20=20=20 * lisp/wdired.el (wdired-do-perm-changes) Use set-file-modes instead of external program. diff --git a/lisp/wdired.el b/lisp/wdired.el index d470e0a21b..34aa61f9ae 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -898,9 +898,8 @@ wdired-do-perm-changes (if (=3D (length perms-new) 10) (progn (setq perm-tmp - (int-to-string (wdired-perms-to-number perms-new))) - (unless (equal 0 (process-file dired-chmod-program - nil nil nil perm-tmp filename)) + (string-to-number (int-to-string (wdired-perms-to-numb= er perms-new)) 8)) + (unless (set-file-modes filename perm-tmp) (setq errors (1+ errors)) (dired-log "%s %s `%s' failed\n\n" dired-chmod-program perm-tmp filename))) --8<-----------------------------cut here---------------end--------------->= 8--- In GNU Emacs 27.0.60 (build 28, x86_64-pc-linux-gnu, GTK+ Version 3.24.5) of 2020-01-25 built on calancha-pc.dy.bbexcite.jp Repository revision: baca81e64141aed076fe088e7160f6e0d4a51c68 Repository branch: emacs-27 Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Recent messages: Tramp: Waiting for prompts from remote shell...done Tramp: Found remote shell prompt on =E2=80=98calancha-pc.dy.bbexcite.jp=E2= =80=99 Tramp: Opening connection for root@calancha-pc.dy.bbexcite.jp using sudo...= done Directory has changed on disk; type g to update Dired Mark set Press C-c C-c when finished or C-c ESC to abort changes C-c C-f is undefined 1 rename actions failed--type ? for details d-elete, u-ndelete, x-punge, f-ind, o-ther window, R-ename, C-opy, h-elp Tramp: Timeout session /sudo:root@calancha-pc.dy.bbexcite.jp: