From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#41531: 28.0.50; proper Eldoc async support Date: Fri, 05 Jun 2020 12:00:57 +0100 Message-ID: <87img5lqty.fsf@gmail.com> References: <87eeqwm101.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="68413"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41531@debbugs.gnu.org, theothornhill@pm.me, mvoteiza@udel.edu, Stefan Monnier , Dmitry Gutov , Fredrik Bergroth To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 05 13:02:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhA7K-000Hg9-92 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 13:02:30 +0200 Original-Received: from localhost ([::1]:36864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhA7J-0000bp-8Q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 07:02:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhA6s-0000af-CM for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 07:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhA6s-0005pH-2U for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 07:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhA6r-0006NU-VW for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 07:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2020 11:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41531 X-GNU-PR-Package: emacs Original-Received: via spool by 41531-submit@debbugs.gnu.org id=B41531.159135487224456 (code B ref 41531); Fri, 05 Jun 2020 11:02:01 +0000 Original-Received: (at 41531) by debbugs.gnu.org; 5 Jun 2020 11:01:12 +0000 Original-Received: from localhost ([127.0.0.1]:48380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhA63-0006MO-VX for submit@debbugs.gnu.org; Fri, 05 Jun 2020 07:01:12 -0400 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:41912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhA5y-0006Lt-Kw for 41531@debbugs.gnu.org; Fri, 05 Jun 2020 07:01:10 -0400 Original-Received: by mail-wr1-f48.google.com with SMTP id j10so9286158wrw.8 for <41531@debbugs.gnu.org>; Fri, 05 Jun 2020 04:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=y7nSKXsjG4BSOHM8rqvk+w+CFeR9SniJOhZn0MnTosI=; b=iCak68Ljf7d9T8hu4hBmCLL9+n76zFUxREb4qwQZ/eCBts9z97B8jcivlg9c6/XcqX oJzdsiLSiy7jidf2xwsd1EF44cXHiTH8/2bS528khqDPZxLNVrZ49QRZw8WoGRt+210z LmEAhmrZO0kgrRRXeb1Di7Bu03XGqR8AL1inlbQGx3CvWoONS3n/jkhwESUCxR9meyhH LEQiw75X7Pr2erQRcMQ/Qw1/ZOE4W8Om94xYfpk0vXxSEmEy9t8/3Tc5bPW+SxV66sdP g7wQocjsq62j378JWy45HSqe0JhDfU6+JKLCvoPrTPB2dw/VwJv+e9aRcis3higEUasF /9nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=y7nSKXsjG4BSOHM8rqvk+w+CFeR9SniJOhZn0MnTosI=; b=HqOlSaOJk29/T2++Gs5jWSQsSYJ7aQpRXhdoGyMdc0QM1Iayt1ig1FtQdLhe54thIR j7L/0cha8eN+ImLqqoQV0Gc31r9pdfuvRZVruy2l7bCODMqdxpSthiW+HoqugT8vIQk5 DJQO3XbEpKmSXa/SZYctMPgU0K1UMf/cUAxK6vGTDsVIt3XoKQHE9wX7KI8E+3RtHEVB FzNJN/0HiLvhNriwBlCUNNozac6kz68ne/0dcn0sbxwgrOhZE4hLhILIVW/dfVxBJGyq uIwz1gCW1BRx0vrnK2hxyhtCOgpgVDAB2MI0y1DjyUDT0efMQpQ6HIBUW84vmu/aa2mL qW+w== X-Gm-Message-State: AOAM531EvtmU4AnzoYGXLSzllqNbsxI/IxiTTfAyQxPlAVWcJgP6UTsm pIXd/kUfK5PTTKEK71THR/8= X-Google-Smtp-Source: ABdhPJzQaKCDxC9MMXDOK8GZeSoRSzZloH6XtDuRdAPwI/Vg2AYpipZwHWMG64Posqbw6GafXRzn7g== X-Received: by 2002:adf:f58b:: with SMTP id f11mr9021417wro.155.1591354860719; Fri, 05 Jun 2020 04:01:00 -0700 (PDT) Original-Received: from krug ([89.180.149.24]) by smtp.gmail.com with ESMTPSA id 1sm10984852wmz.13.2020.06.05.04.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 04:00:59 -0700 (PDT) In-Reply-To: (Andrii Kolomoiets's message of "Thu, 04 Jun 2020 19:20:53 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181545 Archived-At: [ Theodor and Fredrik, adding you since you were also interested in this Eglot/Eldoc matter. You can review the messages in the bug list if you're interested: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41531] Andrii Kolomoiets writes: > I was planning to remove the eglot-put-doc-in-help-buffer variable in > the near future PR as well as the use of the eglot--message function for > the documentation display ;-) I'm guess I'm happy to have shot these plans into the depths of the ocean ;-) > However, after briefly using new Eldoc and Eglot I found some issues > that, I hope, we can fix: > > 1. Display only first line of the hover info. Again :-) You should be able to do this with either (setq eldoc-echo-area-use-multiline-p 1) or (setq eldoc-echo-area-use-multiline-p nil) Did you try this? If so, what exactly didn't work for you when you did? I'm sorry if you've already given me this information in the multiple PR's you opened about this, but let's have it again. > 2. The hover info is sometimes displayed right before the signature info > making the echo area to "blink". I suppose this must be fixed on Eglot > side by not requesting both the hover and the signature infos at the > same time. Not something to be fixed in Eglot, definitely, it's not its fault or responsibility: it just reports whatever it has. I've fixed this in Eldoc, in the last commit. It only affected the "eager" strategy (which should really be called the "enthusiast" strategy). I'll post a commit soon using better names for strategies, I'm thinking: eldoc-documentation-function -> eldoc-strategy (with obsolete alia= s) eldoc-documentation-functions -> eldoc-functions (maybe) eldoc-documentation-default -> eldoc-patient eldoc-documentation-compose -> eldoc-compose-patiently eldoc-documentation-eager -> eldoc-enthusiast (Eglot uses this) -> eldoc-compose-eagerly (Stefan mentioned t= his) > 3. That IMO useless "...truncated, see *help* buffer" message is moved > to Eldoc. Do we really need to show this message every time? I see. Maybe not _every time_ but at least _once_, I'd say. Once per Eldoc session (but what is an Eldoc session)? Once per x truncated messages? Customization variable? (I hate those, but maybe). Or maybe never show it? > That one last line can be used to show additional documentation. > Hadn't a chance to take a closer look at the code, so reporting those > issues is the most I can do for now. Yes, and that's fine for now, though a second pair of eyes in the code is certainly appreciated too. Jo=C3=A3o