From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#41531: 28.0.50; proper Eldoc async support Date: Fri, 05 Jun 2020 17:50:38 +0000 Message-ID: <87img55rmm.fsf@thornhill.no> References: <87eeqwm101.fsf@gmail.com> <87img5lqty.fsf@gmail.com> Reply-To: Theodor Thornhill , Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="36862"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mvoteiza@udel.edu, 41531@debbugs.gnu.org, Fredrik Bergroth , Stefan Monnier , Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 05 20:18:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhGuw-0009PW-9m for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 20:18:10 +0200 Original-Received: from localhost ([::1]:44114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhGuv-00087r-0g for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 14:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhGuo-00086T-Ff for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 14:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhGuo-000431-6i for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 14:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhGuo-0006tC-0t for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 14:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2020 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41531 X-GNU-PR-Package: emacs Original-Received: via spool by 41531-submit@debbugs.gnu.org id=B41531.159138104025585 (code B ref 41531); Fri, 05 Jun 2020 18:18:01 +0000 Original-Received: (at 41531) by debbugs.gnu.org; 5 Jun 2020 18:17:20 +0000 Original-Received: from localhost ([127.0.0.1]:49899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhGu7-0006du-GD for submit@debbugs.gnu.org; Fri, 05 Jun 2020 14:17:20 -0400 Original-Received: from mail-40134.protonmail.ch ([185.70.40.134]:16436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhGUc-0003xO-1z for 41531@debbugs.gnu.org; Fri, 05 Jun 2020 13:51:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1591379451; bh=XKCZNxRwaLTFmCroMCzwpX5+zs0jeepoY5zA0OiEKwA=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=CMlqp/RC6WQ5AoOQzr6hUtqmqA3JHXBvpZJpVZMs8SU5tnP4pJ87u9e/Ic0UGpBL6 kB56V9b7tMVGhq50k7iwPpqG8JIWADhVBiZbLVEynX3UbcmkVHCcktYV5t8ue5Y/Qj lHPR2VdYwn+kye/8UyMFiiYdRoNWe6GEQEqGUDcxx3LPfhXLdAZeF6Mg6SHsqqmXSh wfyOIVp2LIW6WOCFspcSOwFagFoL4Q/gCr2/mszj//PwChV9w0+FAEGwRFb/FPl9Bq RYxStUbsXwdqBUFisG8gKBywFq+fmsrmauOi9vPLy7Mf71htJBg5ZXTCk9X9XwSoSi ID5mRtMRDklSA== In-Reply-To: <87img5lqty.fsf@gmail.com> X-Mailman-Approved-At: Fri, 05 Jun 2020 14:17:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181579 Archived-At: Hello! Thanks for pinging me - I tried it, and it looks pretty cool. However, I noticed a few bugs. (When using both the new eldoc and eglot): Bug 1: =20 1. Open a file 2. Start eglot 3. Hover something with "C-h ." 4. Switch to the new window that popped up. 5. C-x k (kill buffer) 6. Repeat step 3. 7. "invalid buffer" and eldoc is dead.=20 8. Starting and stopping eldoc doesn't work =20 This seems to happen since it uses the new buffer and updates it. When that= buffer is deleted, it gets confused. Bug 2: 1. (setq eldoc-echo-area-use-multiline-p nil) 2. eglot spits the whole thing on one line. This looks a bit weird since it= uses both the signature and the documentation. This may not be a bug, but right now IMO it looks a bit strange. Bug 3: 1. "M-:" 2. Type "(" 3. Minibuffer shows: eldoc-error: (wrong number of arguments (0 . 0) 1) I think the first bug is the most problematic one though :) However, I've started to take a liking to the no options set, with this ver= sion. I think I like the "truncate, press M-x ..." message more than the pr= evious one. All the best, Theodor Jo=C3=A3o T=C3=A1vora writes: > [ Theodor and Fredrik, adding you since you were also interested in this > Eglot/Eldoc matter. You can review the messages in the bug list if > you're interested: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41531= ] > > Andrii Kolomoiets writes: > >> I was planning to remove the eglot-put-doc-in-help-buffer variable in >> the near future PR as well as the use of the eglot--message function for >> the documentation display ;-) > > I'm guess I'm happy to have shot these plans into the depths of the > ocean ;-) > >> However, after briefly using new Eldoc and Eglot I found some issues >> that, I hope, we can fix: >> >> 1. Display only first line of the hover info. Again :-) > > You should be able to do this with either > > (setq eldoc-echo-area-use-multiline-p 1) > > or > > (setq eldoc-echo-area-use-multiline-p nil) > > Did you try this? If so, what exactly didn't work for you when you did? > I'm sorry if you've already given me this information in the multiple > PR's you opened about this, but let's have it again. > >> 2. The hover info is sometimes displayed right before the signature info >> making the echo area to "blink". I suppose this must be fixed on Eglot >> side by not requesting both the hover and the signature infos at the >> same time. > > Not something to be fixed in Eglot, definitely, it's not its fault or > responsibility: it just reports whatever it has. I've fixed this in > Eldoc, in the last commit. It only affected the "eager" strategy (which > should really be called the "enthusiast" strategy). I'll post a commit > soon using better names for strategies, I'm thinking: > > eldoc-documentation-function -> eldoc-strategy (with obsolete al= ias) > eldoc-documentation-functions -> eldoc-functions (maybe) > > eldoc-documentation-default -> eldoc-patient > eldoc-documentation-compose -> eldoc-compose-patiently > eldoc-documentation-eager -> eldoc-enthusiast (Eglot uses this) > -> eldoc-compose-eagerly (Stefan mentioned= this) > >> 3. That IMO useless "...truncated, see *help* buffer" message is moved >> to Eldoc. Do we really need to show this message every time? > > I see. Maybe not _every time_ but at least _once_, I'd say. Once per > Eldoc session (but what is an Eldoc session)? Once per x truncated > messages? Customization variable? (I hate those, but maybe). > > Or maybe never show it? > >> That one last line can be used to show additional documentation. >> Hadn't a chance to take a closer look at the code, so reporting those >> issues is the most I can do for now. > > Yes, and that's fine for now, though a second pair of eyes in the code > is certainly appreciated too. > > Jo=C3=A3o