From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#41645: 27.0.91; Combining Grapheme Joiner (#x34f) gui artifacts Date: Fri, 05 Jun 2020 08:31:24 +0000 Message-ID: <87img53odf.fsf@gmail.com> References: <83zh9merd4.fsf@gnu.org> <83wo4qepab.fsf@gnu.org> <83lfl6eiod.fsf@gnu.org> <83zh9lcuyg.fsf@gnu.org> <87o8q1xohw.fsf@gmail.com> <83d06gcjtp.fsf@gnu.org> <87d06g6vsw.fsf@gmail.com> <834krscfa3.fsf@gnu.org> <87v9k76gq4.fsf@gmail.com> <83zh9jblqj.fsf@gnu.org> <87h7vr5nbs.fsf@gmail.com> <83tuzrarff.fsf@gnu.org> <874krq4fd8.fsf@gmail.com> <83img6arbi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="67867"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dfussner@googlemail.com, 41645@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 05 10:32:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jh7lp-000HVo-No for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 10:32:09 +0200 Original-Received: from localhost ([::1]:58816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jh7lo-0000qK-Qe for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 04:32:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jh7li-0000pz-ND for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 04:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jh7li-0008Gh-DV for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 04:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jh7li-0002fh-9f for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 04:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2020 08:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41645 X-GNU-PR-Package: emacs Original-Received: via spool by 41645-submit@debbugs.gnu.org id=B41645.159134589810236 (code B ref 41645); Fri, 05 Jun 2020 08:32:02 +0000 Original-Received: (at 41645) by debbugs.gnu.org; 5 Jun 2020 08:31:38 +0000 Original-Received: from localhost ([127.0.0.1]:48255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jh7lJ-0002f2-RJ for submit@debbugs.gnu.org; Fri, 05 Jun 2020 04:31:38 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:43998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jh7lI-0002eq-9V for 41645@debbugs.gnu.org; Fri, 05 Jun 2020 04:31:36 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id l10so8801526wrr.10 for <41645@debbugs.gnu.org>; Fri, 05 Jun 2020 01:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rtvXJ/zqUTzfi4PSNCEh/eE3DNHLG5wgAzpnfbdkB7g=; b=qHcpDPURt2T4SABqcBN4ylvPJgRp3SO7rjBK9gGRKe2irKKvOjbB1MUyv/0WH5+EwA zy3lzPMLI0q9mQvvF8ZM8/zLnk+A7N/p03VKbA4dYmT8WSMwtXhw8AZZ5BHS315tMzQL R5XF5uHasyWw5fVALk/ciIXsaf29+yCAPAe3SBiBqvFjlFBvP5WN7J440Dw10lIdjfIB KMgiT3cz6DOjiXoABU7987am/cAldLEmYo09g7x8odgNqsnnDc8RWlvgnfYbVqdUaFVv fNogBImWADVCWJl53Mpn8ZLPFwv2mnYPaIdRECGmKWPl3kNEsXXjRcUpFRZJp+VsR+4/ v1oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rtvXJ/zqUTzfi4PSNCEh/eE3DNHLG5wgAzpnfbdkB7g=; b=KxfjCCQLOrXq4z5qkI+FrH5ohEKCU5XkyinUmm0N1/oqu9dvwdgkB/lgRqnTcBjpho 9mWkNpuGN/PEbAMjWvbVFXbcAaeTkE/oHzDxR9wVScRI3fEktu2Dy6j2Z8tK7GTZFhmg zth3mOykbGS8BURNzCGYKHx2ipih13pLuFMpfO0858p+ukHSUus9OUlDhnKjlNuztpD7 w5QXs9cYH2B7IEYT+zga8e/lp2XhXyGt+a0EeZsKJQGKv980ZJzTA/qmgOOQ4YF1VpYB ENfk7Z5x6sxEY/a6wbb7Pg+GyGPeHSgr3XOm+A+Ey5Hqpeau8VRF8ygH01SyAUjHe5tR 0pJg== X-Gm-Message-State: AOAM533ZfLWE3kKG7Ek/BsrxyxIzUbKYNnru/w5RUUJmzVK1k4M96/yE FQ72T73W9jPf2Y3EhsmT5elgz8aurhY= X-Google-Smtp-Source: ABdhPJxAqvblkhna2t0JmZNy+bbtB7jalBwseSEAC8+R79wculoINf6+guBYaiunI/QY5JllK3IZow== X-Received: by 2002:a5d:5483:: with SMTP id h3mr8702382wrv.10.1591345890470; Fri, 05 Jun 2020 01:31:30 -0700 (PDT) Original-Received: from chametz ([85.248.227.165]) by smtp.gmail.com with ESMTPSA id j11sm11070889wru.69.2020.06.05.01.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 01:31:29 -0700 (PDT) In-Reply-To: <83img6arbi.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Jun 2020 10:45:53 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181540 Archived-At: Eli Zaretskii writes: >> From: Pip Cet >> Cc: dfussner@googlemail.com, 41645@debbugs.gnu.org >> Date: Thu, 04 Jun 2020 22:48:19 +0000 >> >> > The IT_CHARACTER case also does this when the pixel width comes out as >> > zero: >> > >> > it->phys_ascent = it->ascent; >> > it->phys_descent = it->descent; >> >> > That is, it doesn't trust the ascent/descent values from metrics. >> > Should we do the same for compositions, or did you see any reasons to >> > believe the metrics in this case? >> >> The former, I believe. I still think fonts with such glyphs are broken, >> and we should rely as little as possible on what they say about them. >> >> So I've done that in this new version. > > Thanks. Please push to the master branch, with one nit: > >> + if (glyph_not_available_p) >> + { >> + s->font_not_found_p = true; >> + } > > Our style convention is not to use braces when the block entails only > one line. Thanks! I'd changed that code and missed that.