From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36403: 27.0.50; Trivial image.c bugs Date: Fri, 21 Aug 2020 01:32:27 +0200 Message-ID: <87imdcj3lg.fsf@gnus.org> References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22609"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 36403@debbugs.gnu.org, Pip Cet To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 01:33:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8u3b-0005mB-UB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 01:33:19 +0200 Original-Received: from localhost ([::1]:53806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8u3a-000601-HG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 19:33:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8u3K-0005zl-Nv for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 19:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8u3K-0004I4-E6 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 19:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8u3K-0007jE-Ah for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 19:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 23:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159796636128916 (code B ref 36403); Thu, 20 Aug 2020 23:33:02 +0000 Original-Received: (at 36403) by debbugs.gnu.org; 20 Aug 2020 23:32:41 +0000 Original-Received: from localhost ([127.0.0.1]:44435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8u2z-0007W9-9e for submit@debbugs.gnu.org; Thu, 20 Aug 2020 19:32:41 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:35274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8u2w-0007QN-LI for 36403@debbugs.gnu.org; Thu, 20 Aug 2020 19:32:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ad/Ao3T+e9tXUeskoFV1ybUsa/kPH56vcRqWqSlLiAI=; b=TfwRJYY7HDO2dVhqrgZvV2z6hD 0Yh4aSl6V2pgcDi1+YZ897zMRiMPFA/ds4hEEKiNT9Q/GNogK3T2/Lrqy+nyNuIJEGehv/79KPOhI 6yTyR5LIeLZEDuHUGCvZYnnLEnnOmW1K6wqKUhS8HYqmsR7iAauxviJdDf3o5V0CJOlY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8u2m-0004Gv-J5; Fri, 21 Aug 2020 01:32:32 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUcGxogHhsmIh0v KiFEOib///9JOwZRAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QIFBcMGX+9KgQAAAGmSURBVDjLxVPb keQgDJTwBCDBBgBiAzCIBPaY/GM6AWOP9zFXdV/LB2Wr6ZbUAoDfW/i/AL8AkF5K8b+BOHdHl5Tz a8OJeAdJngxvBLcIyWF6MgKgUxXxf7a9tlKIv/ZBACLKrDTibAzGJMwu7wBhJ61wADm0yhS0pqhb b6WKEA5BLMV2cWC/uQCKi2RVvdFWJILzNZNqAqzq3QJUtUl6ryr9XuVduzYVy2Td+RgfDTB7RLaV jIEoYZT0xaubSVktVorES3xVRQQOEOlwg03N+tAWXa0Wni2bxYiDEdCcyn24tc/j9JAyt4JZ8Tmz LavqXremXSRxXBnmGqZDllysgxTX6dkIbN6Eyjk5XOfZw9ve6tanUjrDUwqrr6GwFxs48gnBtoN1 rQ8dSqfU7eMem95NS3y0AiwoExi9JM724w0YsbXBZkMll3W24EowME7gJtpdb90S5ZC1V52fad6g sMcjp+oYgMi8XVhpWU4gGYke88DxTJimn07K4BHz8Qx42k0oK4YngHj1Ci/ANX7MfF3o59XmOZKf XuZB+/b8+AUArxiL8xeaUTbcszVHHwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOC0yMFQyMzox MjoyNCswMDowMP60b0AAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDgtMjBUMjM6MTI6MjQrMDA6 MDCP6df8AAAAAElFTkSuQmCC X-Now-Playing: Telefon Tel Aviv's _Dreams Are Not Enough_: "still as stone in a watery fane." In-Reply-To: <87r1s0j4af.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Aug 2020 01:17:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185799 Archived-At: D'oh. Pip's patch here just had reverse logic -- removing the ! from before the equal_lists fixes the issue for me, so I've now pushed that fix. for (img = c->buckets[i]; img; img = img->next) if (img->hash == hash - && !NILP (Fequal (img->spec, spec)) + && !equal_lists (img->spec, spec) && img->frame_foreground == FRAME_FOREGROUND_PIXEL (f) && img->frame_background == FRAME_BACKGROUND_PIXEL (f)) I guess the !NILP (Fequal...) idiom tainted the rewrite... I've often wondered why we use !NILP instead of, like TRUEP or something. !NILP doesn't feel very natural. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no