From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy) Date: Fri, 28 Aug 2020 16:11:03 +0200 Message-ID: <87imd2vp1k.fsf@gnus.org> References: <871ui48di4.fsf@mail.jurta.org> <878se2aox0.fsf@gnus.org> <87imd669dh.fsf@gnus.org> <875z961u2l.fsf@mail.linkov.net> <871rjt1uc1.fsf@gnus.org> <878se0gc25.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13026"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dani Moncayo , Stefan Kangas , Stefan Monnier , 12443@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 28 16:12:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBf6x-0003Dt-5P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 16:12:11 +0200 Original-Received: from localhost ([::1]:37992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBf6w-0003SS-7t for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 10:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBf6o-0003SF-44 for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 10:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBf6n-000447-RG for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 10:12:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBf6n-0000gS-Le for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 10:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Aug 2020 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12443 X-GNU-PR-Package: emacs Original-Received: via spool by 12443-submit@debbugs.gnu.org id=B12443.15986238782561 (code B ref 12443); Fri, 28 Aug 2020 14:12:01 +0000 Original-Received: (at 12443) by debbugs.gnu.org; 28 Aug 2020 14:11:18 +0000 Original-Received: from localhost ([127.0.0.1]:47034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBf66-0000fF-1O for submit@debbugs.gnu.org; Fri, 28 Aug 2020 10:11:18 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBf63-0000ey-LD for 12443@debbugs.gnu.org; Fri, 28 Aug 2020 10:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ofnoiSZzS3LtbIK8+/Y2krA6iYjXVKbg5VcMgkjAEUg=; b=u83Q+hfhj+V+fTD3bxQUePrCJT r58HfbhjesEKh2Rx0R0cAJdflga/pKIjcIwoTN0N8Vi1TpNFVRZQ5fVlSoOnxk53YXzjhCCo+3lik L7R7z2sVKa4RTtwAFOCSSDvpQRN0EwnkBbQ1KUW71+6dSIIwYBzDjY9NZu8HuhAhHPsI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBf5s-0002xN-Ne; Fri, 28 Aug 2020 16:11:09 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWpuctxj8g9R1r/ //8QJ8S9AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QIHA4FDBXhxbYAAAFlSURBVCjPTZIxj9swDIUf jVMGTyrQ3JCps38FPWS5yQHMAPXcpf4V7trJGW73kBxs/so+ykXuOAj6RIl8TxIgZh2ecTTkT+jT Z8rMdF8FZNj2hPYc3B/AsG3gWrVB3GfUExNVzIIXQl37HgWqMh19FuA0/Xh118Y7Aw5LSqaHzrXl 0Q0Xa5dqLc3G6Tt+ymkOMVrfRebMbkdodP0l9R2UmxR+0zxqsnBzGe5yWJGo85vZFXmcIcWNzFI5 zb4EJOTmbeqtDRjb6uGPYtfMl8b/3s49bRM+3D8WBWsT3JMvOa4s4I5mTQF6pK00uKgZdw4b+/qk YkyWGKcsccbsbHZaXpACWuKw7tqMj2LXtXk/o8hIlpyuCB21Ghvc+lKg4zj4e1cOMdde3XKBEmz9 nEd8hb2AfMko5Anxruh0h/+fQGjb/c/+C/iABLoG77DyLcBDasbrA2vjzh9w7CAt3mKf6G/WvPwD bX2cIoGJqjYAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDgtMjhUMTQ6MDU6MTIrMDA6MDBCuCXs AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA4LTI4VDE0OjA1OjEyKzAwOjAwM+WdUAAAAABJRU5E rkJggg== X-Now-Playing: Mike Oldfield's _Tubular Bells (1)_: "Tubular Bells Part Two" In-Reply-To: <878se0gc25.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 27 Aug 2020 21:48:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186608 Archived-At: Juri Linkov writes: > Maybe the final separator (colon) should be customizable as well. > What if someone wants to use the same character as used in shell, i.e. '$'. > Then moving the currently hard-coded colon to the default value > " (default %s): " will allow the users to customize it to > " (default %s)$ " Good idea. I'll adjust the variable and the code. > Shouldn't one of these calls (namely 'describe-function') be further > simplified with > > diff --git a/lisp/help-fns.el b/lisp/help-fns.el > index d302c05283..617f6ae5e8 100644 > --- a/lisp/help-fns.el > +++ b/lisp/help-fns.el > @@ -151,9 +151,7 @@ describe-function > (let* ((fn (function-called-at-point)) > (enable-recursive-minibuffers t) > (val (completing-read > - (if fn > - (format-prompt "Describe function" fn) > - "Describe function: ") > + (format-prompt "Describe function" fn) > #'help--symbol-completion-table > (lambda (f) (or (fboundp f) (get f 'function-documentation))) > t nil nil > > But something is still wrong - with the nil default value the prompt becomes: > > "Describe function (default nil): " > > whereas it should be > > "Describe function: " Yes, that's why you can't use format-prompt when there's no default value. > It seems 'format-prompt' should not use 'minibuffer-default-prompt-format' > when 'default' is nil. nil is a perfectly valid default value in many prompts. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no