From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43218: EWW handles default answer incorrectly when changing a select Date: Mon, 07 Sep 2020 00:49:37 +0200 Message-ID: <87imcqbjwe.fsf@gnus.org> References: <86ft7wuoq0.fsf@hypra-xx> <878sdn22sf.fsf@gnus.org> <87imcrunvr.fsf@gnus.org> <87tuwaesn3.fsf@gnus.org> <627f040f-2c8f-4a5a-807d-5b4ec0237a03@default> <87k0x6erz5.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36326"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43218@debbugs.gnu.org, Nicolas Graner To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 00:50:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF3U9-0009Kb-OJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 00:50:09 +0200 Original-Received: from localhost ([::1]:58074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kF3U8-0005sK-OR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Sep 2020 18:50:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kF3U2-0005rz-Pr for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 18:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kF3U2-0005Hg-Gj for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 18:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kF3U2-0007Mw-Ew for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 18:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Sep 2020 22:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 43218-submit@debbugs.gnu.org id=B43218.159943260028314 (code B ref 43218); Sun, 06 Sep 2020 22:50:02 +0000 Original-Received: (at 43218) by debbugs.gnu.org; 6 Sep 2020 22:50:00 +0000 Original-Received: from localhost ([127.0.0.1]:47372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF3Tz-0007Mc-VM for submit@debbugs.gnu.org; Sun, 06 Sep 2020 18:50:00 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF3Tx-0007MN-9t for 43218@debbugs.gnu.org; Sun, 06 Sep 2020 18:49:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QCX5PJ/2fv80Dfjmgemnxf3yxINdo0WgBeF0WS42NDU=; b=kjNnC1G5W96Vx8aDjbJLLz4n5Y 1XFl3KEhwlIpdBRk1oQB5Bha7P2D0NnjXOewQRG1iYydXtoV3MjJjdaStxFdhubhI3A9c4iOEQmxP gAw/GiDNVdaCPtVZjZqF7Tjt3bUjgx8Kb3oC53ufqcIRuvSHmmaO7KjUAKmZCWBy1TfI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF3Tf-0006oM-Cm; Mon, 07 Sep 2020 00:49:49 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEX68/N5XoksK1ey oa83KUX///8iHz3tAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QJBhYtDrZDZrMAAAGCSURBVDjLlZRh koMwCIXteIGS5AALcgBt9gAb5P5nWkjsJNr2R5mpE/2E9yCx0/R13BDihrAiQECEn99gC9jW6UZh fwhkxaBcwl9SIVW4TzNs9xzjankAtn60xfq99qRHJFXTh6BaQEvswEKI5Vju8wjcj5MCaT9lqLI/ LlbxCjyKlA8APmSog9FVEWBqzs+AJScEbjkHYBF7gDktWyUQDiBYAbD1bhOQLo7ems3dHLH7Cs/O RZosQZBay0rZDERdQ5Qs1IGExUvZy1R/fmEqdYhNg/wtZn+Z2nz37KCZp0AkRMfYY28QIdlhsC2R JLoMwEcEwUzYaEp0wAMArlt1aDxBqBnILxrUSrmXMaNuEOnJFbeTENyw6lXDWmcfSh3baWuFnsED 4HaRDuru1R2s1TqgOuc2xlOpquU3XcJuHPAo+wyzW6v7Gk+gZdQUDBhGQN3OkLM00P0MgPWd+HJ0 /g7kc8AG2cafr9/wbOcW7ARv1z+AGQvaV8LpBayQ45YjrP9oH72+r/+J8AAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMC0wOS0wNlQyMjo0NToxMyswMDowMKvOQegAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjAtMDktMDZUMjI6NDU6MTMrMDA6MDDak/lUAAAAAElFTkSuQmCC X-Now-Playing: New Fast Automatic Daffodils's _Pigeonhole_: "You Were Lying When You Said You Loved Me" In-Reply-To: (Stefan Monnier's message of "Sun, 06 Sep 2020 14:57:09 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187397 Archived-At: Stefan Monnier writes: > It probably gets removed as a side effect of > something else (e.g. of going through `try-completion`) so it probably > "just" needs more work to actively *preserve* the text-properties. FOUND IT!!!1! Man, the completion stuff nests deep... Anyway, the properties are removed here: diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 864726e3cc..2b188d3e95 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1068,7 +1068,7 @@ completion--replace ;; The properties on `newtext' include things like ;; completions-first-difference, which we don't want to include ;; upon insertion. - (set-text-properties 0 (length newtext) nil newtext) + ;;(set-text-properties 0 (length newtext) nil newtext) ;; Maybe this should be in subr.el. ;; You'd think this is trivial to do, but details matter if you want ;; to keep markers "at the right place" and be robust in the face of To it sounds like it's just nixing out all the text properties because it wants to get rid of completions-first-difference and... other things? If we could identify those other things, then we could remove just them if minibuffer-allow-text-properties is set. I've tried looking at what comes out of the machinery with this "patch", and ... I'm not finding anything much. Does this sound familiar to anybody? I can grep around to see if there's any more, I guess... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no