From: Michael Albinus <michael.albinus@gmx.de>
To: Hugh Daschbach <hugh@ccss.com>
Cc: 43252@debbugs.gnu.org
Subject: bug#43252: 27.1; DBus properties lack type hints or overrides
Date: Thu, 10 Sep 2020 18:57:30 +0200 [thread overview]
Message-ID: <87imclwow5.fsf@gmx.de> (raw)
In-Reply-To: <871rj9k78r.fsf@gmx.de> (Michael Albinus's message of "Thu, 10 Sep 2020 16:59:32 +0200")
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Hugh,
> Reading the BlueZ D-Bus GATT API description, you seem to need only
> basic types and arrays of basic types as properties. So I will start
> adding arrays of basic types. Other, more complex compound types will
> follow later.
I have pushed my recent work to master. dbus-register-property,
dbus-get-property, dbus-get-all-properties and
dbus-get-all-managed-objects shall work now for your byte
array. dbus-set-property will follow tomorrow, as well as other compound
types but array.
>> For the moment, I'll only forward failing tests. Once the paperwork
>> is finalized I'll send you whatever suite of tests I've managed to
>> come up with by then.
>
> Yep, much appreciated!
I had to modify your test a little bit, see appended. It passes now for
me. I have renamed it also to dbus-test05-register-property-types, so we
have all property tests under test05, which makes it more easy to select
these tests in batch.
Does it work for you?
>> Cheers,
>> Hugh
Best regards, Michael.
[-- Attachment #2: Type: text/plain, Size: 1523 bytes --]
(ert-deftest dbus-test05-register-property-types ()
"Check property type preservation for an own service."
(skip-unless dbus--test-enabled-session-bus)
(dbus-ignore-errors (dbus-unregister-service :session dbus--test-service))
(unwind-protect
(let ((byte-array "ByteArray"))
(should
(equal
(dbus-register-property
:session dbus--test-service dbus--test-path
dbus--test-interface byte-array :read
'(:array :byte 1 :byte 2 :byte 3))
`((:property :session ,dbus--test-interface ,byte-array)
(,dbus--test-service ,dbus--test-path))))
(should
(equal
(dbus-get-property
:session dbus--test-service dbus--test-path
dbus--test-interface byte-array)
'(1 2 3)))
;; A test for `dbus-get-property' shall be added.
(let ((result
(dbus-get-all-properties
:session dbus--test-service dbus--test-path
dbus--test-interface)))
(should (equal (cdr (assoc byte-array result)) '(1 2 3))))
(let ((result
(dbus-get-all-managed-objects :session dbus--test-service "/"))
result1)
(should (setq result1 (cadr (assoc dbus--test-path result))))
(should (setq result1 (cadr (assoc dbus--test-interface result1))))
(should (equal (cdr (assoc byte-array result1)) '(1 2 3)))))
;; Cleanup.
(dbus-unregister-service :session dbus--test-service)))
next prev parent reply other threads:[~2020-09-10 16:57 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 0:54 bug#43252: 27.1; DBus properties lack type hints or overrides Hugh Daschbach
2020-09-07 7:48 ` Michael Albinus
2020-09-07 17:35 ` Hugh Daschbach
2020-09-07 18:00 ` Michael Albinus
2020-09-07 19:18 ` Hugh Daschbach
2020-09-08 14:36 ` Michael Albinus
2020-09-09 4:10 ` Hugh Daschbach
2020-09-09 4:25 ` Hugh Daschbach
2020-09-09 13:25 ` Michael Albinus
2020-09-09 16:12 ` Hugh Daschbach
2020-09-09 17:43 ` Michael Albinus
[not found] ` <874ko6979w.fsf@gmx.de>
[not found] ` <87v9gm9x9i.fsf@ccss.com>
2020-09-10 14:59 ` Michael Albinus
2020-09-10 16:57 ` Michael Albinus [this message]
2020-09-10 19:09 ` Hugh Daschbach
2020-09-11 8:46 ` Michael Albinus
2020-09-10 22:53 ` Hugh Daschbach
2020-09-11 9:57 ` Michael Albinus
2020-09-11 14:19 ` Michael Albinus
2020-09-15 4:05 ` Hugh Daschbach
2020-09-16 12:47 ` Michael Albinus
2020-09-16 22:23 ` Hugh Daschbach
2020-09-17 12:58 ` Michael Albinus
2020-09-17 18:42 ` Hugh Daschbach
2020-09-18 6:28 ` Hugh Daschbach
2020-09-18 9:55 ` Michael Albinus
2020-09-18 13:42 ` Michael Albinus
2020-09-18 15:50 ` Michael Albinus
2020-09-18 9:36 ` Michael Albinus
2020-09-19 3:32 ` Hugh Daschbach
2020-09-20 15:05 ` Michael Albinus
2020-09-21 11:50 ` Michael Albinus
2020-09-22 3:48 ` Hugh Daschbach
2020-09-22 16:09 ` Michael Albinus
2020-09-22 17:36 ` Michael Albinus
2020-09-23 3:30 ` Hugh Daschbach
2020-09-23 3:34 ` Hugh Daschbach
2020-09-23 7:44 ` Michael Albinus
2020-09-23 17:32 ` Michael Albinus
2020-09-24 3:02 ` Hugh Daschbach
2020-09-24 8:48 ` Michael Albinus
2020-09-25 4:16 ` Hugh Daschbach
2020-09-26 1:27 ` Hugh Daschbach
2020-09-26 9:51 ` Michael Albinus
2020-09-28 3:00 ` Hugh Daschbach
2020-09-28 12:55 ` Michael Albinus
2020-09-28 23:17 ` Hugh Daschbach
2020-09-29 12:22 ` Michael Albinus
2020-09-29 21:51 ` Hugh Daschbach
2020-09-30 9:34 ` Michael Albinus
2020-09-30 10:42 ` Michael Albinus
2020-09-30 16:39 ` Hugh Daschbach
2020-09-10 8:00 ` bug#43252: Fwd: " Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imclwow5.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=43252@debbugs.gnu.org \
--cc=hugh@ccss.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).