From: Lars Ingebrigtsen <larsi@gnus.org>
To: No Wayman <iarchivedmywholelife@gmail.com>
Cc: 43467@debbugs.gnu.org
Subject: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction
Date: Thu, 17 Sep 2020 18:16:13 +0200 [thread overview]
Message-ID: <87imccnzua.fsf@gnus.org> (raw)
In-Reply-To: <87d02k2xvf.fsf@gmail.com> (No Wayman's message of "Thu, 17 Sep 2020 12:04:20 -0400")
No Wayman <iarchivedmywholelife@gmail.com> writes:
> * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons):
> new defcustom to disable/enable display of warning suppression buttons
> in *Warnings* buffer.
Warnings are something you should rarely get, so I'm not quite sure I
see the use case for this? In any case, some minor comments...
> +(defcustom warning-show-suppression-buttons t
> + "Whether or not to show suppresion buttons in the *Warnings* buffer.
suppression
> +If t, buttons are shown, else they are not."
We usually say "if non-nil", not "t".
> + :type 'boolean)
And there should be a :version here.
> - (unless noninteractive
> + (unless (or noninteractive (not warning-show-suppression-buttons))
And perhaps this would be clearer as a (when (and .. instead.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-09-17 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 15:52 bug#43467: 28.0.50; [PATCH] defcustom warning-show-suppression-buttons No Wayman
2020-09-17 16:04 ` bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction No Wayman
2020-09-17 16:13 ` Robert Pluim
2020-09-17 16:24 ` No Wayman
2020-09-17 16:16 ` Lars Ingebrigtsen [this message]
2020-09-17 17:09 ` No Wayman
2020-09-17 17:27 ` Lars Ingebrigtsen
2020-09-17 18:08 ` No Wayman
2020-09-18 13:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imccnzua.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=43467@debbugs.gnu.org \
--cc=iarchivedmywholelife@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).