From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#40317: 27.0.90; Reverting a buffer that visits C file signals an error Date: Fri, 18 Sep 2020 21:46:03 +0200 Message-ID: <87imcac1hg.fsf@cassou.me> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11754"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie To: Jeff Norden , 40317@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 18 21:59:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJMXI-0002xT-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 21:59:12 +0200 Original-Received: from localhost ([::1]:58460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJMXI-0008PY-0X for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 15:59:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJMLW-0006Dl-Ob for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 15:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJMLW-0006wJ-Cq for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 15:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJMLW-00050f-BK for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 15:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40317 X-GNU-PR-Package: emacs Original-Received: via spool by 40317-submit@debbugs.gnu.org id=B40317.160045836919193 (code B ref 40317); Fri, 18 Sep 2020 19:47:02 +0000 Original-Received: (at 40317) by debbugs.gnu.org; 18 Sep 2020 19:46:09 +0000 Original-Received: from localhost ([127.0.0.1]:44477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJMKf-0004zU-FA for submit@debbugs.gnu.org; Fri, 18 Sep 2020 15:46:09 -0400 Original-Received: from mail.choca.pics ([80.67.172.235]:54694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJMKc-0004zL-3j for 40317@debbugs.gnu.org; Fri, 18 Sep 2020 15:46:08 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 7005718197CC6; Fri, 18 Sep 2020 21:46:04 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id ApmAzeJm6oe2; Fri, 18 Sep 2020 21:46:03 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id DDDF51818FAF3; Fri, 18 Sep 2020 21:46:03 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id ByhFdUvsUOec; Fri, 18 Sep 2020 21:46:03 +0200 (CEST) Original-Received: from localhost (203.99.92.92.rev.sfr.net [92.92.99.203]) by mail.choca.pics (Postfix) with ESMTPSA id 9D6461819576F; Fri, 18 Sep 2020 21:46:03 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188348 Archived-At: --=-=-= Content-Type: text/plain Hi Jeff, Jeff Norden writes: > Unfortunately, I can't figure out how to trigger this bug myself. If you want > to be 100% sure about it, you might try adding > > (if (> c-new-END (point-max)) > (error "c-new-END is too big! %d > %d" c-new-END (point-max))) > > right after line-2009 and see if it raises an error before it gets to > parse-partial-sexp. I wasn't sure if you wanted me to only add the `if` or if you wanted me to also change the previous line. I've just added the `if` with the attached patch and will report if I get the new error message. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=emacs-bug-40317.patch --- a/lisp/progmodes/cc-mode.el.orig 2020-07-29 23:40:41.000000000 +0200 +++ b/lisp/progmodes/cc-mode.el 2020-09-18 15:36:37.409779350 +0200 @@ -2007,6 +2007,10 @@ ;; larger than (beg end). (setq c-new-END (- (+ c-new-END (- end beg)) old-len)) + ;; Trying to fix bug#40317 + (if (> c-new-END (point-max)) + (error "c-new-END is too big! %d > %d" c-new-END (point-max))) + (unless (c-called-from-text-property-change-p) (setq c-just-done-before-change nil) (c-save-buffer-state (case-fold-search) --=-=-=--