From: Lars Ingebrigtsen <larsi@gnus.org>
To: Robert Lange <rlange@corusa.net>
Cc: 44319@debbugs.gnu.org
Subject: bug#44319: make mode should recognize ::= as a macro assignment
Date: Fri, 30 Oct 2020 13:52:20 +0100 [thread overview]
Message-ID: <87imarj2pn.fsf@gnus.org> (raw)
In-Reply-To: <20201029203409.2nvutolbzkimbgpn@iset.darkempire.org> (Robert Lange's message of "Thu, 29 Oct 2020 16:34:09 -0400")
Robert Lange <rlange@corusa.net> writes:
> I've tested this on Emacs 26.1 on Debian, as well as a self-compiled
> 27.1. When I use the GNU immediate assignment operator `:=` the macro
> name ELC_FILES is correctly shown in font-lock in the macro color. But
> if I use the POSIX standard `::=` (well, forthcoming POSIX standard,
> but GNU emacs has supported it since v4.0) ELC_FILES is incorrectly
> shown in the target color.
Yup. This bug is still present in Emacs 28.
> Looking in lisp/progmodes/make-mode.el, the const
> makefile-macroassign-regex is pretty gnarly, but I *think* it should
> match a `::=`, so I'm assuming it's getting preempted by something
> else, probably the const makefile-dependency-regex. Unfortunately,
> that regexp is a bit more than I can interpret, and I don't dare
> change it because I'll almost certainly break some other obscure but
> legal cases.
The bug seemed to be in makefile-match-dependency, which checked for
":=", but not for "::=", and I've now fixed this on the trunk.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-10-30 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 20:34 bug#44319: make mode should recognize ::= as a macro assignment Robert Lange via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-30 12:52 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imarj2pn.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=44319@debbugs.gnu.org \
--cc=rlange@corusa.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).