From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#33341: 27.0.50; Undo log merging and change groups Date: Fri, 27 Nov 2020 02:11:23 +0100 Message-ID: <87im9r38p0.fsf@web.de> References: <877ehk3ve4.fsf@web.de> <87blfkthy7.fsf@gnus.org> <87zh3442zo.fsf@web.de> <87o8jkgoli.fsf@web.de> <878sang90k.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38108"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 33341@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 27 02:12:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiSJ1-0009oK-I2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Nov 2020 02:12:11 +0100 Original-Received: from localhost ([::1]:60690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiSJ0-0005xu-78 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 20:12:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiSIs-0005xb-Ut for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 20:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiSIs-0000BX-Mz for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 20:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiSIs-0005tX-IN for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 20:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Nov 2020 01:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33341 X-GNU-PR-Package: emacs Original-Received: via spool by 33341-submit@debbugs.gnu.org id=B33341.160643949922629 (code B ref 33341); Fri, 27 Nov 2020 01:12:02 +0000 Original-Received: (at 33341) by debbugs.gnu.org; 27 Nov 2020 01:11:39 +0000 Original-Received: from localhost ([127.0.0.1]:43307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiSIU-0005su-SK for submit@debbugs.gnu.org; Thu, 26 Nov 2020 20:11:39 -0500 Original-Received: from mout.web.de ([212.227.15.3]:52747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiSIR-0005se-BC for 33341@debbugs.gnu.org; Thu, 26 Nov 2020 20:11:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1606439485; bh=EkbJSGBX/r5Iy894a/6y2x3bTtl+3d1PTxoPIHWiFFA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=dEA4r1JVU3Tuvw/st7dcKEbsoXaJLeBXTwHsNX9J4WzEsGf1l3oNRDOotmBRpUSCh SQMpxf4bxU3BJiPg5UCnXioJYOI40yVxIijsVlTZ4vbPnTNLHRD1vluT8DLT76xUBt Y02ua3c4vKzttpui4dmwN51i9DBBM4weQtE7rXCo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.218.219.247]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MIvFp-1kkwKa2PFJ-002WLZ; Fri, 27 Nov 2020 02:11:25 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 26 Nov 2020 15:55:42 -0500") X-Provags-ID: V03:K1:W7eu36gyu/Htk1yrGBxLMYpxKGadq8F0uv4pHAINzdGg9irGkrk H36qtgncXu7lGwOzRI+MFN1Z46UfE9dxRZPmPtITe50Vyx/WOGFGR5d9kmstiOvuY2aFSRS 2d0ujq/bvGooCyovCPVZ9BYctHIHapV3WXQQccoNQWD0ETi2WOw1eu2PzSX42iUC0zxWLpx /e97Z18kPq20xkOHPkFdw== X-UI-Out-Filterresults: notjunk:1;V03:K0:u7Ps1YzachI=:DdTtyFT2IiBmI+lOknU0tC 2fNnO0kDqIp410vTy6ueT8xVgJGuRIxqVWbud/YKp2S94A0wRopqMM8Aciv0xhJMdN8qhvjtX mbxkw5iWVRcokjSZE6N//OtrTEKEc1EH8KsSyrTOeHFib3LUB4mlU2qom1judpkBvM9qxKLnO ZISJMYTlZaI9gok9qdjPuqFz7+hzgY6Ou6YWZDiQfcILkNQQROrBDDfDsrSeK8cGf99MTyEMk fS6//omj0DuSzN6kvEdSRf1/1S52uUsq0FNXuRLkNJa3o5BmYxehnqYTVrEDjixQopQYvVhSU RKFtxxUecBFG6iGEL47rtuKwQaZNuhzsySUXSlAVArzhBC1/CtxhBWUSgTYQjv1583O907tT8 qK+cExaZ1mB7/OrAbsVWzvqz1H6XrCCwaqh/dkPNBFkN72GJaSEVKKv3nuzeLdJcSToP6IwX/ H5mK8sNkkR57Q4dQkiAOd82ORBbQse2pennSJTvL3H/bOkmrXs8cV74jv+UfZz0aKXSsGN+ko BHfOIs3G+RfSrKssEB8Qn0HqR0Ksm+ejFSxZImz46bcpkKSdJRPdLEVOBDzZR5NXxhMxwXyR7 NV3h2WQ3NpcCuBXOhyK02zcT44t4SMGxAW/FEO4UuWy9BqBqyg0+u2M7Sg50RjbQ3lk11seGD BDaeZRSd6k75PZbwfcnUe1PepLxS238ed2qi6TF4AO9bINXvdoeXPi20eocbA+q5TMpNFWzaz iC7Iu71ZkC0lzkCPQQeacnPe1sS6Em1slTwWsnPvKdEZc2B7WzrB1UxYmqiFsnEqnAMVNTkd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194387 Archived-At: Stefan Monnier writes: > Could you check why it breaks in the absence of an undo-boundary? I have edebugged `org-entry-get'. Short version: it is as it seems. Here is the example again: #+begin_src emacs-lisp (defun my-test-change-groups () (interactive) (insert "0\n") ;; (undo-boundary) (let ((g (prepare-change-group))) (activate-change-group g) (insert "b\n") (insert "c\n") (cancel-change-group g))) #+end_src Without the boundary, all changes are combined into one (1 . 10) undo entry. And then these code lines #+begin_src emacs-lisp ;; Temporarily truncate the undo log at ELT. (when (consp elt) (setcar elt nil) (setcdr elt nil)) #+end_src cause that were the undo should happen: #+begin_src emacs-lisp ;; Undo it all. (save-excursion (while (listp pending-undo-list) (undo-more 1))) #+end_src nothing is undone. With the boundary, we have two undo entries, and the truncated log still contains the entry for the first `insert' call. Regards, Michael.