From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.bugs Subject: bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Date: Sat, 28 Nov 2020 18:28:14 -0600 Message-ID: <87im9pt3a9.fsf@red-bean.com> References: <87bogubqjy.fsf@gnu.org> <873925ebpd.fsf@gnu.org> <87363ff7qp.fsf@gnus.org> <11ee80e5-6d98-4a1f-93c8-babb6da003f3@default> <87r1qxrgs1.fsf@gnus.org> <87v9g52dvz.fsf@red-bean.com> <875z7x889d.fsf@red-bean.com> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1505"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Chong Yidong , 12507-done@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 29 01:44:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjApB-0000Go-Vl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 01:44:22 +0100 Original-Received: from localhost ([::1]:55332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjApB-0000tB-0x for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Nov 2020 19:44:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjAox-0000qP-HY for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 19:44:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjAox-0002Xs-9r for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 19:44:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kjAox-0002Nb-3x for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 19:44:07 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Karl Fogel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Nov 2020 00:44:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 12507-done@debbugs.gnu.org id=D12507.16066106158951 (code D ref 12507); Sun, 29 Nov 2020 00:44:06 +0000 Original-Received: (at 12507-done) by debbugs.gnu.org; 29 Nov 2020 00:43:35 +0000 Original-Received: from localhost ([127.0.0.1]:49369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjAoR-0002KJ-39 for submit@debbugs.gnu.org; Sat, 28 Nov 2020 19:43:35 -0500 Original-Received: from newsp.red-bean.com ([45.79.25.59]:41944 helo=sanpietro.red-bean.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjAoN-0002Jd-AR for 12507-done@debbugs.gnu.org; Sat, 28 Nov 2020 19:43:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Je/vZaZHWfU6xUAJvCisvOB9edsdEKRk8HQHeAg1BS8=; t=1606610611; x=1607820211; b=Gf+fA8aaEd7SfK1vfo+dYbzkf0SFuAhT8svK8m74FkUsdUbGZvbji8op3eSlI20Zvm00ZXQlgc Hmmb0b43rN7d1pePzMR7HtzEREsUNncvgFNGUlM7wQkw/iTz5UoLT+fGJs84UkdJ3ApMq/A/aUVAC 8uBv0dYYPcktmF2tQmSKZHdDnNOL4xdweQ4SKhy0se4fr0uSW5hipFnoq9/bcaBE7FtGZdnDeQA0Z UfcZwosC8rwBw/tMIehrCx8j3YNbow2PMkXqLtPFGi5WS0Sr4HwlThnim00wd0+X1Sn+pgWdV2A4l uP37Y0dt870Isw+V3q8M3M8mRf7CXxvGAMthg==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:33114 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjAZb-0005xs-Og; Sun, 29 Nov 2020 00:28:15 +0000 In-Reply-To: (Drew Adams's message of "Tue, 29 Sep 2020 08:45:17 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194519 Archived-At: Okay, this is done now: | commit 17fa17be3d93fc10f6ca91d738d5056b1b9f1f1e | Author: Karl Fogel | AuthorDate: Sat Nov 28 18:17:46 2020 -0600 | | Save bookmarks by using `write-file' (bug#12507) | | Go back to using `write-file' to save bookmarks, instead of using | `write-region'. This means numbered backups of the bookmark file may | get made again, depending on the value of `bookmark-version-control'. | | Thanks especially to Drew Adams and Eli Zaretskii for their | persistence in tracking down information relevant to this change. I committed it on the 'emacs-27' branch. That seemed like the right place for a small and safe change like this (in addition to running 'make check', I tested it manually to make sure it has the effects we expected). Although there's been a fair amount of activity in bookmark.el on 'master' recently (e.g., Stefan Kangas's changes to base `bookmark-bmenu-mode' on `tabulated-list-mode', for bug #39293), my commit does not conflict with any of that activity, so there should be no problem when 'emacs-27' is next automerged to 'master'. Closing bug #12507 with this message. Best regards, -Karl On 29 Sep 2020, Drew Adams wrote: >> >What's wrong with the obvious, simple solution to the >> >real, recognized problem of no backups for bookmark >> >files: use `write-file'? That's the first question >> >to ask and answer, no? >> >> I can't think of any reason now. I have a vague memory that there *was* a >> specific reason, but if there was, I failed to document adequately at the >> time and have been unable to recover it now. >> >> Eli helpfully linked to Richard's message >> (https://urldefense.com/v3/__https://lists.gnu.org/archive/html/emacs- >> devel/2005- >> 05/msg01376.html__;!!GqivPVa7Brio!OesHeMbHNKqFeUCyyW2WJ0UeXBZjSXngBYlvA1Q5G9F >> zXXgAa30g7LGrcwolObMB$ ), in which Richard points out that if bookmark visits >> the file anyway when reading, then there's nothing to be gained (from the >> perspective of saveplace.el interference) from avoiding visiting it when >> writing. >> >> And `bookmark-load' *does* visit the file when reading, so I'm leaning toward >> just taking your suggestion and reverting to `write-file' -- but this time >> leaving better historical breadcrumbs (in comments and/or log messages) in >> case my vaguely-remembered bug turns out to be real and reappears. >> >> I will do this as soon as I have time to focus on it and make sure I don't >> make a silly blunder; that may be several days. > >Thanks for looking into this, Karl. (No hurry.)