From: Karl Fogel <kfogel@red-bean.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, Chong Yidong <cyd@gnu.org>,
12507-done@debbugs.gnu.org
Subject: bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist
Date: Sat, 28 Nov 2020 18:28:14 -0600 [thread overview]
Message-ID: <87im9pt3a9.fsf@red-bean.com> (raw)
In-Reply-To: <fe62d513-bc37-4a5c-bb38-ca6f98977a44@default> (Drew Adams's message of "Tue, 29 Sep 2020 08:45:17 -0700 (PDT)")
Okay, this is done now:
| commit 17fa17be3d93fc10f6ca91d738d5056b1b9f1f1e
| Author: Karl Fogel <kfogel@red-bean.com>
| AuthorDate: Sat Nov 28 18:17:46 2020 -0600
|
| Save bookmarks by using `write-file' (bug#12507)
|
| Go back to using `write-file' to save bookmarks, instead of using
| `write-region'. This means numbered backups of the bookmark file may
| get made again, depending on the value of `bookmark-version-control'.
|
| Thanks especially to Drew Adams and Eli Zaretskii for their
| persistence in tracking down information relevant to this change.
I committed it on the 'emacs-27' branch. That seemed like the right place for a small and safe change like this (in addition to running 'make check', I tested it manually to make sure it has the effects we expected).
Although there's been a fair amount of activity in bookmark.el on 'master' recently (e.g., Stefan Kangas's changes to base `bookmark-bmenu-mode' on `tabulated-list-mode', for bug #39293), my commit does not conflict with any of that activity, so there should be no problem when 'emacs-27' is next automerged to 'master'.
Closing bug #12507 with this message.
Best regards,
-Karl
On 29 Sep 2020, Drew Adams wrote:
>> >What's wrong with the obvious, simple solution to the
>> >real, recognized problem of no backups for bookmark
>> >files: use `write-file'? That's the first question
>> >to ask and answer, no?
>>
>> I can't think of any reason now. I have a vague memory that there *was* a
>> specific reason, but if there was, I failed to document adequately at the
>> time and have been unable to recover it now.
>>
>> Eli helpfully linked to Richard's message
>> (https://urldefense.com/v3/__https://lists.gnu.org/archive/html/emacs-
>> devel/2005-
>> 05/msg01376.html__;!!GqivPVa7Brio!OesHeMbHNKqFeUCyyW2WJ0UeXBZjSXngBYlvA1Q5G9F
>> zXXgAa30g7LGrcwolObMB$ ), in which Richard points out that if bookmark visits
>> the file anyway when reading, then there's nothing to be gained (from the
>> perspective of saveplace.el interference) from avoiding visiting it when
>> writing.
>>
>> And `bookmark-load' *does* visit the file when reading, so I'm leaning toward
>> just taking your suggestion and reverting to `write-file' -- but this time
>> leaving better historical breadcrumbs (in comments and/or log messages) in
>> case my vaguely-remembered bug turns out to be real and reappears.
>>
>> I will do this as soon as I have time to focus on it and make sure I don't
>> make a silly blunder; that may be several days.
>
>Thanks for looking into this, Karl. (No hurry.)
prev parent reply other threads:[~2020-11-29 0:28 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87bogubqjy.fsf@gnu.org>
[not found] ` <handler.s.C.13485522721217.transcript@debbugs.gnu.org>
2012-09-25 13:53 ` bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Drew Adams
2012-09-26 2:53 ` Chong Yidong
2012-09-26 3:18 ` Drew Adams
2012-09-26 4:04 ` Stefan Monnier
2012-09-26 14:19 ` Drew Adams
2012-09-26 19:46 ` Stefan Monnier
2012-09-26 20:31 ` Drew Adams
2012-09-26 21:46 ` Karl Fogel
2012-09-26 22:26 ` Drew Adams
2012-09-26 23:36 ` Drew Adams
2012-09-27 15:48 ` Karl Fogel
2012-09-27 16:00 ` Drew Adams
2012-09-27 17:57 ` Karl Fogel
2012-09-27 18:32 ` Drew Adams
2012-09-27 3:24 ` Stefan Monnier
2012-09-24 18:41 ` bug#12507: 24.2.50; `bookmark-write-file': use `write-file', not `write-region', to get backups Drew Adams
2012-09-27 5:38 ` bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Thierry Volpiatto
2012-09-27 18:37 ` Drew Adams
2012-09-27 21:16 ` Thierry Volpiatto
2012-09-28 9:04 ` Thierry Volpiatto
2012-09-28 20:00 ` Drew Adams
2012-09-29 7:42 ` Thierry Volpiatto
2012-09-29 14:36 ` Drew Adams
2012-09-29 15:12 ` Thierry Volpiatto
2012-09-29 15:51 ` Drew Adams
2012-09-29 16:20 ` Thierry Volpiatto
2012-09-29 16:50 ` Drew Adams
2012-09-29 16:57 ` Thierry Volpiatto
2012-10-01 3:38 ` bug#12507: Option `(bookmark-)version-control': Use :tag so doc string matches menu Karl Fogel
2012-10-01 4:06 ` bug#12507: Option `(bookmark-)version-control': Use :tag so docstring " Drew Adams
2012-10-01 4:13 ` bug#12507: Have I mentioned how much I hate Debbugs? Karl Fogel
2012-10-01 4:50 ` Drew Adams
2012-10-01 21:23 ` Karl Fogel
2012-10-01 22:00 ` Drew Adams
2012-10-02 5:31 ` Thierry Volpiatto
2020-11-29 1:07 ` bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Karl Fogel
2012-09-27 8:36 ` bug#12507: `bookmark-write-file': use `write-file', not `write-region', to get backups Juri Linkov
2012-09-27 15:02 ` Drew Adams
2020-09-18 15:02 ` bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Lars Ingebrigtsen
2020-09-18 16:23 ` Drew Adams
2020-09-19 14:18 ` Lars Ingebrigtsen
2020-09-19 17:29 ` Drew Adams
2020-09-23 6:41 ` Karl Fogel
2020-09-23 13:34 ` Lars Ingebrigtsen
2020-09-23 16:23 ` Eli Zaretskii
2020-09-24 13:58 ` Lars Ingebrigtsen
2020-09-29 5:27 ` Karl Fogel
2020-09-29 14:29 ` Lars Ingebrigtsen
2020-09-23 14:27 ` Eli Zaretskii
2020-09-23 18:13 ` Drew Adams
2020-09-23 18:14 ` Drew Adams
2020-09-29 5:25 ` Karl Fogel
2020-09-29 15:45 ` Drew Adams
2020-11-29 0:28 ` Karl Fogel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im9pt3a9.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=12507-done@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).