unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Protesilaos Stavrou <info@protesilaos.com>
To: 44937@debbugs.gnu.org
Cc: Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive
Date: Sun, 29 Nov 2020 02:25:11 +0200	[thread overview]
Message-ID: <87im9p3t7c.fsf@protesilaos.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

In light of the latest feedback in bug#44424, please find attached a
patch that makes the new log-view-commit-body face look exactly like the
design it replaced in log-view buffers.

The idea is to avoid introducing a disruptive change, while still
providing a face that themes or users can configure to match their
needs.

What do you think?

-- 
Protesilaos Stavrou
protesilaos.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-log-view-commit-body-less-intrusive.patch --]
[-- Type: text/x-patch, Size: 1399 bytes --]

From 7ca7f7918f4d03aeab5d67fd72ea371443ac174f Mon Sep 17 00:00:00 2001
From: Protesilaos Stavrou <info@protesilaos.com>
Date: Sun, 29 Nov 2020 02:10:43 +0200
Subject: [PATCH] Make log-view-commit-body less intrusive

* lisp/vc/log-view.el (log-view-commit-body): Inherit from
font-lock-comment-face.  This makes expanded commit messages in
log-view look the same as they did prior to commit 1f0b929430 (consult
bug#44424).
---
 lisp/vc/log-view.el | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index 56ecc64671..e7b6eea807 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -208,15 +208,7 @@ If it is nil, `log-view-toggle-entry-display' does nothing.")
   "Face for the message header line in `log-view-mode'."
   :group 'log-view)
 
-(defface log-view-commit-body
-  '((((class color) (min-colors 88) (background light))
-     :background "gray95" :foreground "black" :extend t)
-    (((class color) (min-colors 88) (background dark))
-     :background "gray5" :foreground "white" :extend t)
-    (((class color) (min-colors 8) (background light))
-     :foreground "black")
-    (((class color) (min-colors 8) (background dark))
-     :foreground "white"))
+(defface log-view-commit-body '((t :inherit font-lock-comment-face))
   "Face for the commit body in `log-view-mode'."
   :version "28.1")
 
-- 
2.29.2


             reply	other threads:[~2020-11-29  0:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29  0:25 Protesilaos Stavrou [this message]
2020-11-29 10:44 ` bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive Lars Ingebrigtsen
2020-11-29 10:51   ` Dmitry Gutov
2020-11-29 11:11     ` Protesilaos Stavrou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im9p3t7c.fsf@protesilaos.com \
    --to=info@protesilaos.com \
    --cc=44937@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).