unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Francesco Potortì" <pot@gnu.org>
Cc: 44617@debbugs.gnu.org
Subject: bug#44617: 26.3; diff-mode ignores diff-switches
Date: Sun, 06 Dec 2020 14:51:08 +0100	[thread overview]
Message-ID: <87im9fcab7.fsf@gnus.org> (raw)
In-Reply-To: <E1klek3-002UaW-U6@tucano.isti.cnr.it> ("Francesco Potortì"'s message of "Sat, 05 Dec 2020 22:05:19 +0100")

Francesco Potortì <pot@gnu.org> writes:

>>What's the use case you have for diff-switches where you'd want this
>>command to heed diff-switches?
>
> I have two use cases.
>
> 1) When using dired-diff (hit = in a dired buffer) diff-switches is not used.
>
> 2) Same is when using vc-diff (C-x v =) in a VC buffer.
>
> Apparently case 2) is a bug, because the docs of vc-diff-switches says
> that diff-switches should be used.  Case 1) could simply be unexpected
> behaviour.

I 1), diff-switches is always used, so I can't reproduce that problem at
all -- changing diff-switches and using the `=' command reflects the
changed switches.  Do you have that command rebound, by any chance?

As for 2), `diff-switches' is indeed used, but only when `vc-diff-switches'
is nil, as the doc string says:

--
When running diff under a given BACKEND, VC uses the first
non-nil value of ‘vc-BACKEND-diff-switches’, ‘vc-diff-switches’,
and ‘diff-switches’, in that order. 
--

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-12-06 13:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 12:11 bug#44617: 26.3; diff-mode ignores diff-switches Francesco Potortì
2020-11-13 16:11 ` Unknown
2020-11-13 16:31   ` Unknown
2020-11-13 16:31   ` Unknown
2020-11-14 16:25 ` Lars Ingebrigtsen
2020-12-05 21:05   ` Francesco Potortì
2020-12-06 13:51     ` Lars Ingebrigtsen [this message]
2020-12-06 23:39       ` Francesco Potortì
2020-12-06 23:41         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im9fcab7.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=44617@debbugs.gnu.org \
    --cc=pot@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).