From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45819: 28.0.50; time-stamp-tests failures Date: Tue, 12 Jan 2021 16:55:10 +0000 Message-ID: <87im82nlht.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9398"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: stephen gildea To: 45819@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 12 17:56:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzMxr-0002Lt-8O for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 17:56:15 +0100 Original-Received: from localhost ([::1]:56354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzMxq-00005v-4w for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 11:56:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzMxf-0008UV-QO for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 11:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49639) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzMxf-0006FN-H5 for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 11:56:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzMxe-00072r-Eh; Tue, 12 Jan 2021 11:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: stepheng+emacs@gildea.com, bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jan 2021 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45819 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: stephen gildea Original-Received: via spool by submit@debbugs.gnu.org id=B.161047053327043 (code B ref -1); Tue, 12 Jan 2021 16:56:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jan 2021 16:55:33 +0000 Original-Received: from localhost ([127.0.0.1]:32951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzMxB-000726-5R for submit@debbugs.gnu.org; Tue, 12 Jan 2021 11:55:33 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:48958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzMx7-00071x-Ul for submit@debbugs.gnu.org; Tue, 12 Jan 2021 11:55:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzMx3-0007nC-65 for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 11:55:28 -0500 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:53423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzMwu-0005u3-Bg for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 11:55:21 -0500 Original-Received: by mail-wm1-x331.google.com with SMTP id k10so2508731wmi.3 for ; Tue, 12 Jan 2021 08:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version; bh=AQy/bfLFYEi6lK/ZCHpWnKBnM3x91eVh5FxXUDN5rek=; b=Sz3+lbdzrnPuvpgxaHTCg4ReHnzWsFo1Zx26bA4MA5edIsZqoUr0ijLL2G9EqNq4LS jkH3lFhl1VwWOmSWeZpI8pZFb067V5fHFbeb0ZGQVNpGekWOiYUfeKUPed3dJFk3ILv1 gq2IHqRN3WNUqD/6jHLZV8ABsx1FC6TeO28I2EEQi8CkfbQ33Cj9FIvVlTLGpZPcmRzU 8zrpzLWddmZkx6snczlm1hgS6We52sPUDbYLalGToyQQTEg/rK94OU8FNb7nRClR7f6H iyyxGExXAx+J86UZh8c8npw5Zf08ZcmCGiWph3XBV9HwKLLKDTg6/kbQk35fAuFFL72+ Ueqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=AQy/bfLFYEi6lK/ZCHpWnKBnM3x91eVh5FxXUDN5rek=; b=OJkx3g/b6KAOdxC8MAY5tS6ToF4O1RFXHVlAn8P1cCL+MEXYcRjsTO9D/O5ZoyWiMP XYmnyrbJX24QRSiyUPFvk55PWzhhvVUhKkdZ49dfhZtzbHGybQgWzYzaCOnhaKZEC3C4 G80XuuaB6KicOkmXT0HomVoi80IORhnJmtM1GsaKZOdp8qEBYB3VHn+yQ8/U79YSRsKW 4jTY4dYTh3UQE+22trIPO4b+J2AmjtWUGR7EZLRM87MESTvPyDdZ4NBu3Xhi+fFhw9RF szjPTv9ITUyHQl5jy8wm07WQLGJboDkwZ9u9o4/kBsND6HWgK7AOOvdz+DY+IKGp5axQ rk7Q== X-Gm-Message-State: AOAM530FAOW8D66VLgW6fhshmZZsOJ6gxz357steNaYBOE5csVOKwgtE oRzzPjnNRsutsRaBxeFWqpij2hICki1xCX+S X-Google-Smtp-Source: ABdhPJyFxjqq8xETujszze/B8hg9kxR6SvBl+MvkL3gRlaE3WbYcu1U7Sdefb6FZPiSzcUfWvHaWTQ== X-Received: by 2002:a7b:c19a:: with SMTP id y26mr219102wmi.20.1610470512263; Tue, 12 Jan 2021 08:55:12 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id v11sm5719964wrt.25.2021.01.12.08.55.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 08:55:11 -0800 (PST) Received-SPF: none client-ip=2a00:1450:4864:20::331; envelope-from=contovob@tcd.ie; helo=mail-wm1-x331.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197807 Archived-At: --=-=-= Content-Type: text/plain X-Debbugs-Cc: Stephen Gildea I've been seeing the attached failures in time-stamp-format-am-pm, time-stamp-format-ignored-modifiers, and time-stamp-format-string-width for a while now. My guess is that all three are failing because AM/PM format is not supported in my locale, and so '%p' returns an empty string, as per (info "(libc) Formatting Calendar Time"). Should the tests be changed to just also handle an empty/blank string, or is a more complicated fix required? Thanks, -- Basil In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2021-01-12 built on tia Repository revision: ca024b0575c4ea754c4c6e6dbf21ed610e0d1fb8 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12010000 System Description: Debian GNU/Linux bullseye/sid Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --enable-checking=structs --with-x-toolkit=lucid --with-file-notification=yes --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XAW3D XDBE XIM XPM LUCID ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline; filename=time-stamp-tests.log Content-Transfer-Encoding: quoted-printable Running 27 tests (2021-01-12 16:30:45+0000, selector =E2=80=98(not (or (tag= :expensive-test) (tag :unstable)))=E2=80=99) passed 1/27 time-stamp-custom-count (0.000162 sec) passed 2/27 time-stamp-custom-end (0.000067 sec) passed 3/27 time-stamp-custom-format-tabs-expand (0.000161 sec) passed 4/27 time-stamp-custom-inserts-lines (0.000088 sec) passed 5/27 time-stamp-custom-pattern (0.000928 sec) passed 6/27 time-stamp-custom-time-zone (0.000124 sec) Test time-stamp-format-am-pm backtrace: signal(ert-test-failed (((should (equal (time-stamp-string "%#p" ref ert-fail(((should (equal (time-stamp-string "%#p" ref-time1) "pm"))=20 #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name time-stamp-format-am-pm :documentatio ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/time-stamp-tests" "- command-line() normal-top-level() Test time-stamp-format-am-pm condition: (ert-test-failed ((should (equal (time-stamp-string "%#p" ref-time1) "pm")) :form (equal "" "pm") :value nil :explanation (arrays-of-different-length 0 2 "" "pm" first-mismatch-at 0))) FAILED 7/27 time-stamp-format-am-pm (0.000081 sec) passed 8/27 time-stamp-format-day-number-in-week (0.000068 sec) passed 9/27 time-stamp-format-day-of-month (0.000077 sec) passed 10/27 time-stamp-format-day-of-week (0.000069 sec) passed 11/27 time-stamp-format-hours-12 (0.000093 sec) passed 12/27 time-stamp-format-hours-24 (0.000092 sec) Test time-stamp-format-ignored-modifiers backtrace: signal(ert-test-failed (((should (equal (time-stamp-string "%.,@-+_=20 ert-fail(((should (equal (time-stamp-string "%.,@-+_ ^(stuff)P" ref- #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name time-stamp-format-ignored-modifiers : ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/time-stamp-tests" "- command-line() normal-top-level() Test time-stamp-format-ignored-modifiers condition: (ert-test-failed ((should (equal (time-stamp-string "%.,@-+_ ^(stuff)P" ref-time3) "AM")) :form (equal " " "AM") :value nil :explanation (array-elt 0 (different-atoms (32 "#x20" "? ") (65 "#x41" "?A"))))) FAILED 13/27 time-stamp-format-ignored-modifiers (0.000074 sec) passed 14/27 time-stamp-format-minute (0.000109 sec) passed 15/27 time-stamp-format-month-name (0.000061 sec) passed 16/27 time-stamp-format-month-number (0.000075 sec) passed 17/27 time-stamp-format-non-conversions (0.000035 sec) passed 18/27 time-stamp-format-non-date-conversions (0.000074 sec) passed 19/27 time-stamp-format-second (0.000074 sec) Test time-stamp-format-string-width backtrace: signal(ert-test-failed (((should (equal (time-stamp-string "%1P" ref ert-fail(((should (equal (time-stamp-string "%1P" ref-time3) "A")) : #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name time-stamp-format-string-width :docum ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/time-stamp-tests" "- command-line() normal-top-level() Test time-stamp-format-string-width condition: (ert-test-failed ((should (equal (time-stamp-string "%1P" ref-time3) "A")) :form (equal " " "A") :value nil :explanation (array-elt 0 (different-atoms (32 "#x20" "? ") (65 "#x41" "?A"))))) FAILED 20/27 time-stamp-format-string-width (0.000074 sec) passed 21/27 time-stamp-format-time-zone-name (0.000095 sec) passed 22/27 time-stamp-format-time-zone-offset (0.000125 sec) passed 23/27 time-stamp-format-year-2digit (0.000113 sec) passed 24/27 time-stamp-format-year-4digit (0.000040 sec) passed 25/27 time-stamp-helper-safe-locals (0.000051 sec) passed 26/27 time-stamp-helper-string-defaults (0.000069 sec) passed 27/27 time-stamp-helper-zone-type-p (0.000041 sec) Ran 27 tests, 24 results as expected, 3 unexpected (2021-01-12 16:30:45+000= 0, 0.232066 sec) 3 unexpected results: FAILED time-stamp-format-am-pm FAILED time-stamp-format-ignored-modifiers FAILED time-stamp-format-string-width --=-=-=--