unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 45917@debbugs.gnu.org
Subject: bug#45917: [PATCH] Use big brackets in Calc in big mode
Date: Tue, 19 Jan 2021 16:45:01 +0100	[thread overview]
Message-ID: <87im7thqwy.fsf@gnus.org> (raw)
In-Reply-To: <C1A66960-9AD1-4A90-9C3C-6A40B2CB3C48@acm.org> ("Mattias Engdegård"'s message of "Tue, 19 Jan 2021 11:12:05 +0100")

Mattias Engdegård <mattiase@acm.org> writes:

> 19 jan. 2021 kl. 06.37 skrev Lars Ingebrigtsen <larsi@gnus.org>:
>
>> ... would it be possible to have a fallback if the display doesn't
>> support these characters?
>
> Yes, all Unicode characters are checked using char-displayable-p in
> the patch.

Duh.  I skimmed the patch, but I missed that bit...

> However, some characters may be technically displayable but
> not very pretty, or have awkward metrics.
>
> That said, the brackets look fine where I've tested them so it's
> probably not a serious concern.

Yup.

>> Yeah.  Or there could be a variable to allow the user to not use these
>> fancy brackets if this is important for them?
>
> Maybe, but Calc already has rather too many variables and should we
> have separate variables for all non-ASCII features then, like the
> square root sign?

Possibly?  But I see you've just pushed a fix for parsing the root
sign.  :-)

> We are just speculating here. I'd hoped for concrete cheerful evidence
> like 'looks terrible on my terminal', 'completely destroys
> embedded-mode for me'...

I'm guessing you won't get feedback like that until you push this
change.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-01-19 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16 17:10 bug#45917: [PATCH] Use big brackets in Calc in big mode Mattias Engdegård
2021-01-19  5:37 ` Lars Ingebrigtsen
2021-01-19 10:12   ` Mattias Engdegård
2021-01-19 15:45     ` Lars Ingebrigtsen [this message]
2021-01-19 17:59       ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im7thqwy.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=45917@debbugs.gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).