From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41836: 26.3; Could we stop `help-buffer' from ever signalling errors? Date: Thu, 21 Jan 2021 17:04:53 +0100 Message-ID: <87im7q8ee2.fsf@gnus.org> References: <871rmj9js2.fsf@orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35932"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41836@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 21 17:06:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2cTM-0009DG-Mh for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 17:06:12 +0100 Original-Received: from localhost ([::1]:53722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2cTL-0003nW-NE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 11:06:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2cTC-0003lv-Hz for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 11:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2cTC-0007jD-9I for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 11:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l2cTC-0004yq-3G for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 11:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jan 2021 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41836 X-GNU-PR-Package: emacs Original-Received: via spool by 41836-submit@debbugs.gnu.org id=B41836.161124510719039 (code B ref 41836); Thu, 21 Jan 2021 16:06:02 +0000 Original-Received: (at 41836) by debbugs.gnu.org; 21 Jan 2021 16:05:07 +0000 Original-Received: from localhost ([127.0.0.1]:59133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2cSJ-0004x1-FR for submit@debbugs.gnu.org; Thu, 21 Jan 2021 11:05:07 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:58998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2cSH-0004wL-FZ for 41836@debbugs.gnu.org; Thu, 21 Jan 2021 11:05:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a6//u1peSP0ROHfQbyV+w43mYj//kdJr6VTkyQpb4eE=; b=eiThLIUlX+yjdqn7MFLS2jQht6 rg48KE9PPjYPoI3sNEw2G3Ir3ftF59Acvfqx524qKAFDY411hcSdyerkGF7KUpNrUrsM/V0shZM0A dud2zOGDXT+jfpPdz6XcJmdSDFYbEEgJymuIVmsMO0+fUgQ/wLFIjb7LSQuHCQwDJw+0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2cS7-0006gk-VG; Thu, 21 Jan 2021 17:04:58 +0100 X-Now-Playing: Richard Bone's _Third Noise Principle (Formative North American Electronica 1975-1984) (1)_: "Mambopolis" In-Reply-To: <871rmj9js2.fsf@orcon.net.nz> (Phil Sainty's message of "Sun, 14 Jun 2020 01:29:01 +1200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198319 Archived-At: Phil Sainty writes: > My motivation is from wondering whether it was simple to > display all of the function and variable symbols displayed by > `so-long-commentary' as help buttons. I found that calling > `help-make-xrefs' does exactly that, but then trying to use any > of the buttons causes the "Current buffer is not in Help mode" > error. > > With the suggested change I get the desirable behaviour of those > help buttons popping up a help window with the relevant help. > It seems to work beautifully for my use-case, and would surely > be equally useful in other similar situations. > > Is there any good reason to maintain that error? Looking at the code, my impression is that `help-make-xrefs' is meant to be used in `help-mode' buffers only, and the `error' call is just a sanity check for that, kinda? Lifting the restriction by removing that `error' would allow other usages. I'm not sure whether they're all taken into account, though. Anybody got an opinion here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no