From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24383: 25.1.50; Deprecation/internalization of `read-from-whole-string' Date: Sat, 06 Feb 2021 13:37:51 +0100 Message-ID: <87im759xsw.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6244"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 24383@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 06 13:39:35 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8Ms9-0001Uo-Vl for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Feb 2021 13:39:34 +0100 Original-Received: from localhost ([::1]:34754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8Ms9-0005cy-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Feb 2021 07:39:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8Mrf-0005aE-8I for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 07:39:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8Mre-0003Qy-5b for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 07:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l8Mre-00080C-2E for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 07:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Feb 2021 12:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24383 X-GNU-PR-Package: emacs Original-Received: via spool by 24383-submit@debbugs.gnu.org id=B24383.161261508530678 (code B ref 24383); Sat, 06 Feb 2021 12:39:02 +0000 Original-Received: (at 24383) by debbugs.gnu.org; 6 Feb 2021 12:38:05 +0000 Original-Received: from localhost ([127.0.0.1]:45390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8Mqj-0007yj-7d for submit@debbugs.gnu.org; Sat, 06 Feb 2021 07:38:05 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:52592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8Mqh-0007y9-QV for 24383@debbugs.gnu.org; Sat, 06 Feb 2021 07:38:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NQtAGgGF0Il1IrHvm7LVBPfvbshBd2QQtanXzIf3QhY=; b=gwehM/V9e/Q42ko3m4F7A8MFX+ a0NSo/Txcm9xZIiWFuB/O528AlWO19Xs3e+7tE2/G/YgXE3Tm80EIKbzOsK1AegeRM6bE+pdaY9Mo Hbmo3Pgi8yKNOVTI2PbDKoAPg0eEFPgGPkoz4JBXbt4YMHjtaNU4a10sf6fRpzJo1V2U=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8MqX-0005da-9s; Sat, 06 Feb 2021 13:37:57 +0100 X-Now-Playing: Dayteller's _Shining Bright (The Songs of Lal & Mike Waterson)_: "Fine Horseman" In-Reply-To: (Drew Adams's message of "Tue, 6 Sep 2016 09:52:12 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199433 Archived-At: Drew Adams writes: > What's the rationale behind the demotion of `read-from-whole-string' > and its replacement by "internal" function > `thing-at-point--read-from-whole-string'? > > "This is an internal thingatpt function and should not be used." > > Should not be used? Really? Why? "Should not be used" is perhaps over-stating the case, but it's an internal thingatpt function with a name that didn't reflect that, so renaming it is appropriate. > Based on this (seemingly gratuitous) change, existing user code now > has to fiddle, to be usable in more than one Emacs version (versions > 0 to 24.5 vs version 25.1). > > (if (fboundp 'read-from-whole-string) > (read-from-whole-string strg) > (thing-at-point--read-from-whole-string strg)) It's up to you whether you want to use internal Emacs functions, of course. Closing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no