From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames. Date: Sun, 14 Feb 2021 20:50:40 +0200 Organization: LINKOV.NET Message-ID: <87im6ulbzz.fsf@mail.linkov.net> References: <871rdv4xog.fsf@gmail.com> <87a6sfu0fi.fsf@mail.linkov.net> <87v9b2ifrz.fsf@mail.linkov.net> <55ebad56-b440-198a-653e-1660040d5eae@gmx.at> <38b988fd-2ad6-a596-23a0-1d765249f718@gmx.at> <87tuqjydku.fsf@mail.linkov.net> <871rdlr4vc.fsf@mail.linkov.net> <87ft1zsu75.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9027"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 46299@debbugs.gnu.org To: Bastian Beranek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 14 19:59:00 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBMbj-0002Ce-4q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 19:58:59 +0100 Original-Received: from localhost ([::1]:38350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBMbi-0003AX-6F for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 13:58:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBMWx-0006EY-GK for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 13:54:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBMWx-0007Vw-9V for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 13:54:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBMWx-0003p9-8u for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 13:54:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Feb 2021 18:54:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46299 X-GNU-PR-Package: emacs Original-Received: via spool by 46299-submit@debbugs.gnu.org id=B46299.161332880414614 (code B ref 46299); Sun, 14 Feb 2021 18:54:03 +0000 Original-Received: (at 46299) by debbugs.gnu.org; 14 Feb 2021 18:53:24 +0000 Original-Received: from localhost ([127.0.0.1]:36702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBMWK-0003ne-4a for submit@debbugs.gnu.org; Sun, 14 Feb 2021 13:53:24 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:39957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBMWG-0003mj-45 for 46299@debbugs.gnu.org; Sun, 14 Feb 2021 13:53:20 -0500 Original-Received: from mail.gandi.net (m91-129-108-204.cust.tele2.ee [91.129.108.204]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id D99C5100007; Sun, 14 Feb 2021 18:53:12 +0000 (UTC) In-Reply-To: (Bastian Beranek's message of "Sun, 14 Feb 2021 14:08:55 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200025 Archived-At: >> Thank you for working on this patch. Please prepare the ChangeLog >> commit message, so your patch could be pushed to master. Then it would be >> easier to reason about further changes and base them on the pushed version. > > please find the patch including the commit message with ChangeLog attached. Thanks, now your patch is pushed to master. While using it, I noticed a new problem. There is this code in 'tab-switcher': (let ((tab-bar-new-tab-choice t) ;; Don't enable tab-bar-mode if it's disabled (tab-bar-show nil)) (tab-bar-new-tab)) Before your patch, I did nothing with the enabled tab-bar, but now it disables the tab-bar, and doesn't enable it again later, because tab-bar-show is let-bound to nil. A good solution would be to add a new choice value to tab-bar-show. Something like 'do-not-change-tab-bar-lines', but shorter. Then when let-bound, it should do nothing with the tab-bar-lines. Also this is related to another problem: What if the user wants to manually enable the tab bar on one frame only without enabling tab-bar-mode? Currently it's possible with (add-hook 'after-make-frame-functions 'toggle-frame-tab-bar) But tab-bar--update-tab-bar-lines will disable it sooner or later. Customizing to the same value like 'do-not-change-tab-bar-lines' will solve this problem as well.