From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#47026: 28.0.50; Allow Gnus summary faces to extend to end of line Date: Tue, 16 Mar 2021 19:15:32 +0100 Message-ID: <87im5r2ce3.fsf@gmail.com> References: <87czw8p3dt.fsf@gmail.com> <87sg53hwev.fsf@gnus.org> <87lfas8clj.fsf@gmail.com> <87k0q8vtap.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32490"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47026@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 16 19:21:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMEJl-0008H8-HW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Mar 2021 19:21:21 +0100 Original-Received: from localhost ([::1]:52672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMEJk-0004wz-CO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Mar 2021 14:21:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMEEe-0001B2-RV for bug-gnu-emacs@gnu.org; Tue, 16 Mar 2021 14:16:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMEEc-0006pI-Kn for bug-gnu-emacs@gnu.org; Tue, 16 Mar 2021 14:16:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMEEc-0005rD-Fu for bug-gnu-emacs@gnu.org; Tue, 16 Mar 2021 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Mar 2021 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 47026-submit@debbugs.gnu.org id=B47026.161591854422489 (code B ref 47026); Tue, 16 Mar 2021 18:16:02 +0000 Original-Received: (at 47026) by debbugs.gnu.org; 16 Mar 2021 18:15:44 +0000 Original-Received: from localhost ([127.0.0.1]:41009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMEEJ-0005qd-Ap for submit@debbugs.gnu.org; Tue, 16 Mar 2021 14:15:43 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:39911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMEEF-0005qN-Ks for 47026@debbugs.gnu.org; Tue, 16 Mar 2021 14:15:41 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id 124-20020a1c00820000b029010b871409cfso1981560wma.4 for <47026@debbugs.gnu.org>; Tue, 16 Mar 2021 11:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=t0xdCvKYXslrRD/m8rCFyU/Ayyb2RmrnKFhh6CxBbcE=; b=Si8sXJr2QFSXKb/oBVKr2G7hfmHad9XQuhDOlYEjBICS2EBQRkzOYis8P+dwadOe48 zW7NxWGirVq6gIrztNVBufXjv7bAs7GU1YZqGo9oA4JAS/OiDOm8uaCf1GP907EEeunf k/q6ROd91YS69FjrKEk8So9DfWvPj9YCzAHf9ZvLcqWmb2JYyBMjdvOIKRCcRryl+C7b gQ/9qusaMuyvEoJz6KlA5tjq/wW0iFTcvoRoXENyPOMkpb6xbnbpl2oGlObIkdXMpZuS 70IHP6rjST2DuiQcli6j64d+2/iOvnHSfxAvscWPmlAE+70/I/Ntd/OTRrZFvKA8lWGL Ggzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=t0xdCvKYXslrRD/m8rCFyU/Ayyb2RmrnKFhh6CxBbcE=; b=CgCbCQ0YyJPQJHZO/qu2ALOgRiKm6NxRjC1NsZ7/IIPjAl5FQxEUkY22NnO/wdCBm1 nmjfwLDt4lxWUgGeFXautxVqXl1dX3bVEWHk89o1rvifHT6Q0YCkQRT2jC2YhwsaLPY8 munQk6ZJJR3uNW8WKVra0a3uL4d57zU4iandWffbXo1WI7IfoDsHhSI8O617FGZXUf9s fop0rQGk7QwahAbed8MlHkOilQ6BUpF8x/09kDYKAZMlWwxLQTVBAZW+nspT+tNfbFUK Cc3XA9PKYtg0mzsEX5bVFdFo9M45CEyDintymaTE4EEnHjkRh4ll8I8/FWltqvwjZilK 9ZSg== X-Gm-Message-State: AOAM533DKGyUea7OLBelFf2oJb0maqVfbYj9XAhBhSiyF/O6UCHQy8DT dKPcasy6O0GTZxEw8bVtRYpVvFUUBtmSBw== X-Google-Smtp-Source: ABdhPJzOXQ9tYnS1WDR5dgK9DJXJK2jfT1uSQfWfaf8jMc3PCriUjcfwe2tibyrrd6sKLeDnU8RgRA== X-Received: by 2002:a05:600c:4f10:: with SMTP id l16mr165255wmq.46.1615918533554; Tue, 16 Mar 2021 11:15:33 -0700 (PDT) Original-Received: from my-little-tumbleweed ([2a01:e0a:20e:d340:922b:34ff:fe95:9aed]) by smtp.gmail.com with ESMTPSA id c2sm172313wmr.22.2021.03.16.11.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 11:15:32 -0700 (PDT) In-Reply-To: <87k0q8vtap.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 16 Mar 2021 01:25:18 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202475 Archived-At: Lars Ingebrigtsen writes: > K=C3=A9vin Le Gouguec writes: > >> Thinking about it some more, I wonder whether the summary faces >> (e.g. gnus-summary-selected, gnus-summary-selected) should be defined >> with :extend t? >> >> It's not a decision to make lightly of course, since :extend is special >> in that themes inherit the value from the original definition. I do >> think it makes sense though; for gnus-summary-selected at least, I find >> that it makes it easier to keep track of the currently selected article. > > I think that makes sense -- I mean, that's how Gnus displayed these > things before Emacs was changed (incompatibly) in how faces on newline > characters is displayed. > > That is, I think adding :extend t to most Gnus summary faces just brings > us back to how it was designed to be displayed. Mmm, unless I'm missing something, before my patch, the face was not applied to the final newline, so even with :extend t the rest of the line was not highlighted. To double-check, I just fired up 26.3, removed %( and %) from gnus-summary-line-format, added a background to gnus-summary-selected, and opened a summary buffer: sure enough, the background stopped at the last character, without extending to the window edge. (Sorry if I'm misunderstanding your point) Regardless, if we agree that :extend t makes sense, I'll cook up a patch sometime next week if nobody beats me to it (a bit swamped at the moment). Thank you for your time.