From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.bugs Subject: bug#46502: 28.0.50; [feature/native-comp] (d3a399dd) native-comp bootstrap failure Date: Sun, 04 Apr 2021 22:56:40 -0400 Message-ID: <87im51bfrr.fsf@md5i.com> References: <87o8gn8ciy.fsf@md5i.com> <83h7m95tt2.fsf@gnu.org> <83ft1s2mp1.fsf@gnu.org> <83a6rz15jm.fsf@gnu.org> <831rdb0yt9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: mwd@md5i.com, Pip Cet , 46502@debbugs.gnu.org, akrl@sdf.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 05 04:57:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTFQU-000158-Hq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Apr 2021 04:57:18 +0200 Original-Received: from localhost ([::1]:56588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTFQT-0004p2-Fg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 22:57:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTFQE-0004ow-Q7 for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 22:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTFQE-0004Vs-J5 for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 22:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lTFQE-0002hM-HZ for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 22:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Welsh Duggan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Apr 2021 02:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46502 X-GNU-PR-Package: emacs Original-Received: via spool by 46502-submit@debbugs.gnu.org id=B46502.161759141310356 (code B ref 46502); Mon, 05 Apr 2021 02:57:02 +0000 Original-Received: (at 46502) by debbugs.gnu.org; 5 Apr 2021 02:56:53 +0000 Original-Received: from localhost ([127.0.0.1]:36689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTFQ5-0002gy-0l for submit@debbugs.gnu.org; Sun, 04 Apr 2021 22:56:53 -0400 Original-Received: from md5i.com ([75.151.244.229]:59094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTFQ2-0002gj-LN for 46502@debbugs.gnu.org; Sun, 04 Apr 2021 22:56:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=D2tGkxsp62Ol5/g2Ymr8Tnu+7fPxNADGFyRF0+8RkUM=; b=iZQrZLVhLLCFYaFoZ9CUvXk1zP aqojsOM6E2UfGa70IsPi+jCzGiyxQgapp0MiItyepYIcv8WLxC0ZUVm7d3MKvBLWSPNHVYZcK8ICI IWt3jlG8IhLB26XW8yPbR4yMB; Original-Received: from abode.md5i.com ([192.168.177.1] helo=miko) by md5i.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lTFPt-003ucZ-IB; Sun, 04 Apr 2021 22:56:41 -0400 In-Reply-To: (Stefan Monnier's message of "Sun, 04 Apr 2021 18:49:29 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203580 Archived-At: Stefan Monnier writes: > Ping? Sorry. Wasn't able to trigger a failure on Friday. (I tried.) And I've had other things to do on the weekend. I'll be trying again Monday morning. > > Stefan Monnier [2021-02-20 12:12:54] wrote: > >>>> One of the possibility is always the inlining (where we either inline >>>> the source code or the bytecode depending on whether the function to be >>>> inlined has already been byte-compiled). >>> That's what it looks like. Are we supposed to fold constants in both cases? >> >> Not sure what you mean by "fold constants", but when inlining byte-code >> we "disassemble" the byte code into LAP code (which is just like byte >> code but represented as a Lisp list with symbols) an then splice that >> into the LAP code of the caller. So it tends to lead to slightly less >> good code because we don't get to apply the source-level optimizer to >> the combination of the caller and callee (but we still do apply the >> bytecode (so called "peephole") optimizer). >> >> For example, Mattias's new constant propagation code and the resulting >> constant folding opportunities doesn't work as well. >> >> We could change the way `defsubst` works so we *always* inline the >> source code[1] (but at the cost of having to keep the source code >> around). But it doesn't seem worth it: we already have `cl-defsubst` >> which does just that, and we also have `define-inline` which can do an >> even better job. >> >>>> Can you try the patch below to see if it makes a difference? >>> It does, no difference with the patch. >> >> So the effect of the patch is that the build is now (more) reproducible? >> >> >> Stefan >> >> >> [1] except when cross-inlining from different dialects, of course. > -- Michael Welsh Duggan (md5i@md5i.com)